-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize easter-theme & Remove 13:37 Easter egg #329
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #329 +/- ##
=======================================
Coverage 53.45% 53.45%
=======================================
Files 33 33
Lines 4553 4553
Branches 267 267
=======================================
Hits 2434 2434
Misses 2069 2069
Partials 50 50 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise. Needs to catch up with upstream.
I've merged #305 into next, we need to resolve the merge conflicts in this PR |
@miniJmo should this PR be closed? |
@krestenlaust yeah if it is merged, then just close it |
Only #305 has been merged AFAIK |
Nvm, looks like I already reverted the other one in favor of this one. I'll be merging this then |
Merge when? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my machine. I'll just go ahead and rename the PR, then I'll get it merged
Things changed in the easter theme:
Builds on the #305 pull request