Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Assign number to new areas/iterations and allow searching by it #2311

Merged
merged 5 commits into from
Oct 10, 2018

Conversation

kwk
Copy link
Collaborator

@kwk kwk commented Oct 8, 2018

Existing iterations and areas are not touched and won't have a number
assigned to them. This will come in a later change.

This is a code-only change to proof that it is backwards compatible.

See https://openshift.io/openshiftio/Openshift_io/plan/detail/618

Most of the code in this change comes from this PR which was later revered: #2311

Existing iterations and areas are not touched and won't have a number
assigned to them. This will come in a later change.

This is a code-only change to proof that it is backwards compatible.

See https://openshift.io/openshiftio/Openshift_io/plan/detail/618
@kwk kwk self-assigned this Oct 8, 2018
@codecov
Copy link

codecov bot commented Oct 8, 2018

Codecov Report

Merging #2311 into master will increase coverage by 0.07%.
The diff coverage is 91.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2311      +/-   ##
==========================================
+ Coverage   70.09%   70.17%   +0.07%     
==========================================
  Files         174      175       +1     
  Lines       16796    16843      +47     
==========================================
+ Hits        11773    11819      +46     
- Misses       3889     3891       +2     
+ Partials     1134     1133       -1
Impacted Files Coverage Δ
space/space.go 69.64% <ø> (ø) ⬆️
iteration/iteration.go 64.83% <100%> (+0.19%) ⬆️
controller/area.go 92.3% <100%> (+0.04%) ⬆️
area/area.go 74.5% <100%> (+0.25%) ⬆️
controller/iteration.go 78.38% <100%> (+0.05%) ⬆️
workitem/expression_compiler.go 81.17% <100%> (ø) ⬆️
numbersequence/human_friendly_number.go 90.69% <90.69%> (ø)
controller/workitem.go 78.83% <0%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87bf305...98103f1. Read the comment docs.

@kwk kwk changed the title WIP: Assign number to new areas/iterations and allow searching by it Assign number to new areas/iterations and allow searching by it Oct 8, 2018
@kwk kwk requested a review from tinakurian October 8, 2018 13:47
@kwk kwk merged commit 11904c7 into fabric8-services:master Oct 10, 2018
@kwk kwk deleted the area-iteration-number branch October 10, 2018 11:49
kwk pushed a commit to openshiftio/saas-openshiftio that referenced this pull request Oct 30, 2018
# Changes

**Commit:** fabric8-services/fabric8-wit@11904c7
**Author:** Konrad Kleine (193408+kwk@users.noreply.github.com)
**Date:** 2018-10-10T13:49:39+02:00

Assign number to new areas/iterations and allow searching by it (fabric8-services/fabric8-wit#2311)

----

**Commit:** fabric8-services/fabric8-wit@8674b7b
**Author:** Konrad Kleine (193408+kwk@users.noreply.github.com)
**Date:** 2018-10-10T16:58:17+02:00

update number for existing iterations (fabric8-services/fabric8-wit#2314)

----

**Commit:** fabric8-services/fabric8-wit@e67b5e2
**Author:** nurali-techie (nurali.techie@gmail.com)
**Date:** 2018-10-15T14:00:33+05:30

stop calling analytics api for cve scan reg/de-reg (fabric8-services/fabric8-wit#2316)

----

**Commit:** fabric8-services/fabric8-wit@37a913a
**Author:** Baiju Muthukadan (baiju.m.mail@gmail.com)
**Date:** 2018-10-15T17:07:20+05:30

Include fabric8-common as a dependency (fabric8-services/fabric8-wit#2318)

----

**Commit:** fabric8-services/fabric8-wit@e09b805
**Author:** Konrad Kleine (193408+kwk@users.noreply.github.com)
**Date:** 2018-10-15T14:44:35+02:00

Use Postgres CTE to update iteration numbers (fabric8-services/fabric8-wit#2319)

----

**Commit:** fabric8-services/fabric8-wit@1724c15
**Author:** Ibrahim Jarif (jarifibrahim@gmail.com)
**Date:** 2018-10-23T10:12:56+05:30

Rearrage search repository blackbox tests (fabric8-services/fabric8-wit#2322)

----

**Commit:** fabric8-services/fabric8-wit@7fda6af
**Author:** Ibrahim Jarif (jarifibrahim@gmail.com)
**Date:** 2018-10-23T13:49:11+05:30

Make agile default template for space creation (fabric8-services/fabric8-wit#2323)

----

**Commit:** fabric8-services/fabric8-wit@7b78cf6
**Author:** Konrad Kleine (193408+kwk@users.noreply.github.com)
**Date:** 2018-10-23T11:54:01+02:00

Postpone iteration number update (fabric8-services/fabric8-wit#2325)

----

**Commit:** fabric8-services/fabric8-wit@22e3d5d
**Author:** Dhriti Shikhar (dhriti.shikhar.rokz@gmail.com)
**Date:** 2018-10-23T16:06:35+05:30

Enable the delete workitem endpoint (fabric8-services/fabric8-wit#2305)

----

**Commit:** fabric8-services/fabric8-wit@3d163c7
**Author:** Ibrahim Jarif (jarifibrahim@gmail.com)
**Date:** 2018-10-23T17:45:11+05:30

Increase deployment timeout to 2X (fabric8-services/fabric8-wit#2327)

----

**Commit:** fabric8-services/fabric8-wit@9879836
**Author:** Ibrahim Jarif (jarifibrahim@gmail.com)
**Date:** 2018-10-24T11:30:20+05:30

Do not throw 500 on invalid value type in search API (fabric8-services/fabric8-wit#2321)

----

**Commit:** fabric8-services/fabric8-wit@44739f8
**Author:** Ibrahim Jarif (jarifibrahim@gmail.com)
**Date:** 2018-10-25T10:57:03+05:30

Remove redundant code and fix typo (fabric8-services/fabric8-wit#2329)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants