Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

update number for existing iterations #2314

Merged

Conversation

kwk
Copy link
Collaborator

@kwk kwk commented Oct 10, 2018

This updates all existing iterations and assigns a number to each iteration partitioned by space and in ascending order by creation time.

This change also makes the number a not-NULLable column on the iterations.

Also a constraint (iterations_space_id_number_idx) is created that ensures an iteration number can only occur once per iteration.

@kwk kwk self-assigned this Oct 10, 2018
@kwk kwk requested a review from tinakurian October 10, 2018 13:55
@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #2314 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2314      +/-   ##
==========================================
+ Coverage   70.15%   70.16%   +0.01%     
==========================================
  Files         175      175              
  Lines       16843    16844       +1     
==========================================
+ Hits        11816    11819       +3     
+ Misses       3892     3891       -1     
+ Partials     1135     1134       -1
Impacted Files Coverage Δ
migration/migration.go 69.28% <100%> (+0.11%) ⬆️
workitem/workitem_repository.go 68.02% <0%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11904c7...2dcd881. Read the comment docs.

@kwk kwk merged commit 8674b7b into fabric8-services:master Oct 10, 2018
@kwk kwk deleted the update-number-for-existing-iterations branch October 10, 2018 14:58
kwk added a commit to kwk/fabric8-wit that referenced this pull request Oct 23, 2018
kwk added a commit that referenced this pull request Oct 23, 2018
Currently the database migration 110 won't go through on prod-preview. I'm postponing it for now.

* Reverts "update number for existing iterations (#2314)"
   * This reverts commit 8674b7b.
* Revert "Use Postgres CTE to update iteration numbers (#2319)"
  * This reverts commit e09b805.
kwk pushed a commit to openshiftio/saas-openshiftio that referenced this pull request Oct 30, 2018
# Changes

**Commit:** fabric8-services/fabric8-wit@11904c7
**Author:** Konrad Kleine (193408+kwk@users.noreply.github.com)
**Date:** 2018-10-10T13:49:39+02:00

Assign number to new areas/iterations and allow searching by it (fabric8-services/fabric8-wit#2311)

----

**Commit:** fabric8-services/fabric8-wit@8674b7b
**Author:** Konrad Kleine (193408+kwk@users.noreply.github.com)
**Date:** 2018-10-10T16:58:17+02:00

update number for existing iterations (fabric8-services/fabric8-wit#2314)

----

**Commit:** fabric8-services/fabric8-wit@e67b5e2
**Author:** nurali-techie (nurali.techie@gmail.com)
**Date:** 2018-10-15T14:00:33+05:30

stop calling analytics api for cve scan reg/de-reg (fabric8-services/fabric8-wit#2316)

----

**Commit:** fabric8-services/fabric8-wit@37a913a
**Author:** Baiju Muthukadan (baiju.m.mail@gmail.com)
**Date:** 2018-10-15T17:07:20+05:30

Include fabric8-common as a dependency (fabric8-services/fabric8-wit#2318)

----

**Commit:** fabric8-services/fabric8-wit@e09b805
**Author:** Konrad Kleine (193408+kwk@users.noreply.github.com)
**Date:** 2018-10-15T14:44:35+02:00

Use Postgres CTE to update iteration numbers (fabric8-services/fabric8-wit#2319)

----

**Commit:** fabric8-services/fabric8-wit@1724c15
**Author:** Ibrahim Jarif (jarifibrahim@gmail.com)
**Date:** 2018-10-23T10:12:56+05:30

Rearrage search repository blackbox tests (fabric8-services/fabric8-wit#2322)

----

**Commit:** fabric8-services/fabric8-wit@7fda6af
**Author:** Ibrahim Jarif (jarifibrahim@gmail.com)
**Date:** 2018-10-23T13:49:11+05:30

Make agile default template for space creation (fabric8-services/fabric8-wit#2323)

----

**Commit:** fabric8-services/fabric8-wit@7b78cf6
**Author:** Konrad Kleine (193408+kwk@users.noreply.github.com)
**Date:** 2018-10-23T11:54:01+02:00

Postpone iteration number update (fabric8-services/fabric8-wit#2325)

----

**Commit:** fabric8-services/fabric8-wit@22e3d5d
**Author:** Dhriti Shikhar (dhriti.shikhar.rokz@gmail.com)
**Date:** 2018-10-23T16:06:35+05:30

Enable the delete workitem endpoint (fabric8-services/fabric8-wit#2305)

----

**Commit:** fabric8-services/fabric8-wit@3d163c7
**Author:** Ibrahim Jarif (jarifibrahim@gmail.com)
**Date:** 2018-10-23T17:45:11+05:30

Increase deployment timeout to 2X (fabric8-services/fabric8-wit#2327)

----

**Commit:** fabric8-services/fabric8-wit@9879836
**Author:** Ibrahim Jarif (jarifibrahim@gmail.com)
**Date:** 2018-10-24T11:30:20+05:30

Do not throw 500 on invalid value type in search API (fabric8-services/fabric8-wit#2321)

----

**Commit:** fabric8-services/fabric8-wit@44739f8
**Author:** Ibrahim Jarif (jarifibrahim@gmail.com)
**Date:** 2018-10-25T10:57:03+05:30

Remove redundant code and fix typo (fabric8-services/fabric8-wit#2329)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants