-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dockerHost cannot be set on a per-execution basis anymore, worked in 0.11.3 #320
Comments
do you happen to know the last version it stopped working in? would it be possible for you to walk back versions to when it stopped? |
There was a change which prevents multiple initialisations of the plugin. However, this also prevents to pick up different Docker host for each execution. This is indeed a bug. |
In order to avoid dangerous and tedious state management for the initialization of ServiceHub, the ServiceHub is now created for each run afresh from a ServiceHubFactory which is needed because of collection Maven dependencies (hence it is configured as a component). This will allow multiple docker host configurations again and will fix #320. Some minor cleanup is probably still needed. ServiceHub should probably called DmpContext as it is now the context given through from which all backend services (which are stateful because of the DockerUrl) are reachable.
Added just a fix for that @BigSocial could you try the |
@rhuss Thanks. We'll try it in the next couple days and let you know. |
@rhuss Yes. That works perfectly. Thanks! |
Using multiple executions to deploy to multiple docker hosts no longer works. It worked in 0.11.3.
In the example below, the plugin attempts to deploy all containers to the
${ois.db}
host, ignoring the dockerHost elements in the other executions. This worked perfectly in 0.11.3.The text was updated successfully, but these errors were encountered: