-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix to add support for multiple docker services #281
Conversation
Signed-off-by: Noam Krendel <nkrendel@gmail.com>
Interesting use case (which I never thought about ;-). SInce the Docker URL is a plugin-global param, I guess you have a multi-module setup ? Would you mind to post some example for this setup so that I can reproduce it ? |
Yes it's a multi-module setup. The root pom defines the plugin and has skip=true. Then there are two sub-modules that each build a war. One sub-module builds the regular api endpoint war and another sub-module builds the admin api endpoint war. These are deployed to different hosts so each sub-module has a configuration with a different dockerHost. e.g.:
Please let me know if you'd like me to post more pieces from this example. |
Thanks, I will tackle the issue for the next (0.13.6) release since its a bit more involved (and needs some extra thoughts) |
I refactored the usage of the I pushed a version |
Support for multiple docker hosts seems to be working in |
cool. I'll close this PR, feel free to reopen it or create an issue if there are still problems. |
I ran across this problem with trying to use the plugin to stop/remove/build/start images on two docker hosts. ServiceHub was only initialized once and so the second docker configuration used the services that were initialized with the old docker url. This is an attempt to fix that.