Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need for the openshift-client dependency #4014

Closed
shawkins opened this issue Mar 28, 2022 · 5 comments
Closed

Remove the need for the openshift-client dependency #4014

shawkins opened this issue Mar 28, 2022 · 5 comments

Comments

@shawkins
Copy link
Contributor

There are things in the openshift client that prevent it from being an api only dependency. We'd have to refactor to account for:

  • Operations that contribute at the collection level, like ProjectOperations
  • Operations that read logs, there's no existing exposed method on Client for this.
  • the client logic that switches the httpclient / configuration to openshift specific. OpenShiftConfig, Readiness, and the OpenShiftOAuthInterceptor could all be moved to client to facilitate this.
  • OpenShiftNamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl - it's a whole other abstraction
  • CreateOnlyResourceOperationsImpl
  • ManagedOpenShiftClient

Originally posted by @shawkins in #3966 (comment)

@shawkins shawkins added this to the 6.x milestone Mar 28, 2022
@linnjason678
Copy link

Is an open shift better process to be in ?

@linnjason678
Copy link

Is removing open shift better for the client,

@stale
Copy link

stale bot commented Jul 3, 2022

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Jul 3, 2022
@stale stale bot removed the status/stale label Jul 6, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 28, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 28, 2022
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Dec 12, 2022
@manusa manusa closed this as completed in 1c68777 Dec 12, 2022
@manusa
Copy link
Member

manusa commented Dec 12, 2022

I believe there are still some actions to be taken in the scope of this issue.

@manusa manusa reopened this Dec 12, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Dec 20, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Dec 21, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Dec 21, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Dec 21, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Dec 22, 2022
@shawkins
Copy link
Contributor Author

shawkins commented May 1, 2023

Marking as closed. There is too much refactoring to make this happen any time soon.

@shawkins shawkins closed this as completed May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants