Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4014: adding support for build version, and removing the context #4613

Merged
merged 1 commit into from
Dec 12, 2022
Merged

fix #4014: adding support for build version, and removing the context #4613

merged 1 commit into from
Dec 12, 2022

Conversation

shawkins
Copy link
Contributor

Description

Furthers #4014 by removing some duplication of logic with openshift builds. It appears that we'd need to create a specialized extensible resource, or add all of the TimestampBytesLimitTerminateTimeTailPrettyLoggable logic to the BaseOperation. Only then, and with more refinement of the log parameters / wait logic, would BuildOperationsImpl be able to made api only.

In looking at this I noticed that the version parameter was not yet wired in, so that has been added.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa added this to the 6.3.0 milestone Dec 12, 2022
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

14.8% 14.8% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 1c68777 into fabric8io:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shawkins @manusa