Ignore unknown properties when deserializing ExecCredential #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`aws-iam-authenticator token --cluster-id <cluster-id>` returns a JSON blob of the form
```
{
"kind": "ExecCredential",
"apiVersion": "client.authentication.k8s.io/v1alpha1",
"spec": {},
"status": {
"expirationTimestamp": "2018-11-28T02:24:39Z",
"token": "<some token>"
}
}
```
This fails to deserialize in `ExecCredentialStatus`. There is a TODO to add some fields, including `expirationTimestamp`, but this is a temporary stopgap to avoid requiring those fields.
|
Can one of the admins verify this patch? |
|
ok to test |
rohanKanojia
requested changes
Nov 28, 2018
oscerd
requested changes
Nov 28, 2018
oscerd
approved these changes
Nov 28, 2018
|
Ok to test |
|
[merge] |
|
Amends #1224 FTR. I saw no such errors when testing my original patch; not sure what the difference is between my environment and others’. |
|
I'm getting this with latest 4.4.1 version of the fabric8-maven-plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws-iam-authenticator token --cluster-id <cluster-id>returns a JSON blob of the formThis fails to deserialize in
ExecCredentialStatus. There is a TODO to add some fields, includingexpirationTimestamp, but this is a temporary stopgap to avoid requiring those fields.