Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore unknown properties when deserializing ExecCredential #1280

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Ignore unknown properties when deserializing ExecCredential #1280

merged 2 commits into from
Nov 30, 2018

Commits on Nov 28, 2018

  1. Ignore unknown properties when deserializing ExecCredential 

    `aws-iam-authenticator token --cluster-id <cluster-id>` returns a JSON blob of the form
```
{
  "kind": "ExecCredential",
  "apiVersion": "client.authentication.k8s.io/v1alpha1",
  "spec": {},
  "status": {
    "expirationTimestamp": "2018-11-28T02:24:39Z",
    "token": "<some token>"
  }
}
```
This fails to deserialize in `ExecCredentialStatus`. There is a TODO to add some fields, including `expirationTimestamp`, but this is a temporary stopgap to avoid requiring those fields.
    @seshness
    seshness authored Nov 28, 2018
    Configuration menu
    Copy the full SHA
    0b69833 View commit details
    Browse the repository at this point in the history

  2. Adds to CHANGELOG.md

    @seshness
    seshness committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    c8c39bb View commit details
    Browse the repository at this point in the history