Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): PR git actions #7593

Closed
ShaMan123 opened this issue Jan 9, 2022 · 10 comments
Closed

feat(ci): PR git actions #7593

ShaMan123 opened this issue Jan 9, 2022 · 10 comments
Assignees

Comments

@ShaMan123
Copy link
Contributor

ShaMan123 commented Jan 9, 2022

I was thinking of adding git actions on PRs:

  1. when committing to the PR - build dist and commit to the PR, or use [codesandbox PR builder] ci(): codesandbox #8135 (https://codesandbox.io/docs/ci)
  2. when merging to master - checkout dist new build, dist might be out for good
  3. lint commit action
  4. Code Coverage Summary comment bot - should remove it's prior comment from thread to avoid spamming, [action](https://github.com/marketplace/actions/delete-comment)
  5. action to update/build website on release - feat(ci): PR git actions #7593 (comment)
@asturur
Copy link
Member

asturur commented Jan 9, 2022

if the git history does not get extremely polluted, that is fine for me. If deleting the branch after merge deletes the history with it.
Not sure if you can checkout dist when merging.

Not sure how the additional commit will eventually trigger new git actions that will trigger another build and so on.
Is the aim to have always a built file available somewhere?

@ShaMan123
Copy link
Contributor Author

yes it is.
and not to do it manually.
3. lint commit action

@ShaMan123
Copy link
Contributor Author

@stale
Copy link

stale bot commented Jan 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Jan 31, 2022
@ShaMan123 ShaMan123 removed the stale Issue marked as stale by the stale bot label Feb 1, 2022
@ShaMan123 ShaMan123 self-assigned this Feb 1, 2022
@ShaMan123
Copy link
Contributor Author

@asturur asturur added the feature label Feb 7, 2022
@asturur
Copy link
Member

asturur commented Feb 7, 2022

Label your own issues if you want to avoid the stale bot to bother you

@ShaMan123
Copy link
Contributor Author

I'm talking about the PR bots they have

@asturur
Copy link
Member

asturur commented Feb 7, 2022

i meant this thing here
image

When you want to rise something you know is worth, give it a label so stale-bot does not come here

@ShaMan123
Copy link
Contributor Author

great thanks

@ShaMan123 ShaMan123 added the CI/CD label Feb 7, 2022
@ShaMan123
Copy link
Contributor Author

ShaMan123 commented Apr 2, 2022

https://github.com/marketplace/actions/trigger-workflow-and-wait

Triggering updates to fabricjs.com (build_docs) from fabric.js release workflow.
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants