-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(): codesandbox #8135
ci(): codesandbox #8135
Conversation
Give me time to read it so i learn something new. In general i don't have much to say on this PR, i ll merge it for sure, i just want to read it |
|
||
const DEV_MODE = process.env.NODE_ENV === "development"; | ||
|
||
export function useCanvas( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may want to simplify this method
I took it from existing code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for example saveState
isn't so good because if code changes in the init
block it doesn't take effect on hot reload, but only on hard reload
So maybe I should remove it entirely
It will be bad if the sandbox raises bugs because it is supposed to be a clean, safe bug repro w/o interference....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a deploy script
so you can test the templates by running
npm run dev sandbox -- --template node/next/vanilla
OHH this will make prototyping so much easier!
@ShaMan123 since our last chat i have blocked with the back and i can barely sit. |
Merging knowing this may have killed node 14 |
Sorry to hear about your back The description is not good enough, for sure.
please explain. I didn't expect this |
build.lock
#8290 and update from masteradd codesandbox ci to fabric for issues/PR and for prototyping (even on your local machine!)
https://codesandbox.io/docs/ci
I think I managed to install the github ci app on fabric..if not please do
The issue you (@asturur ) had of codesandbox not opening should be resolved by using this tool because it should build the repo behind scenes with their engine and expose it for sandboxes to use (instead of containing a build file inside the sandbox)
.codesandbox
ci.json
- generic configtemplates
- a folder containing templates to create a sandboxes fromdeploy.js
- deploys the template to codesandboxscripts
- exposedsandbox
cmd withbuild
start
deploy
Try It