fix(Group): patch2 minors

[asturur]

This PR rename canEnter in canEnterGroup and move canEnterGroup to an higher level of the logic so that it can stops adding not supported objects to groups.

Background color has been left in for group since the layers in group concept may be slow to enter fabricjs.

[asturur]

replace #7900
@ShaMan123 have a look at this solution to catching the issue before need to throw

[github-actions]

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.05 |    75.93 |   85.71 |   82.78 |                                               
 fabric.js |   83.05 |    75.93 |   85.71 |   82.78 | ...,30840,30914,30925-30990,31113,31212,31448 
-----------|---------|----------|---------|---------|-----------------------------------------------

[github-actions]

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.05 |    75.93 |   85.71 |   82.78 |                                               
 fabric.js |   83.05 |    75.93 |   85.71 |   82.78 | ...,30842,30916,30927-30992,31115,31214,31450 
-----------|---------|----------|---------|---------|-----------------------------------------------

[github-actions]

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.06 |    75.96 |   85.71 |   82.79 |                                               
 fabric.js |   83.06 |    75.96 |   85.71 |   82.79 | ...,30842,30916,30927-30992,31115,31214,31450 
-----------|---------|----------|---------|---------|-----------------------------------------------

[ShaMan123]

This is much better no doubt.

However:

The advantage of moving it to add/insertAt is clear. That's how it should be. The disadvantage is a drop in perf for large groups because we add an iteration over objects. Unless we manage to change collection logic to run all logic on object in one single iteration

Originally posted by @ShaMan123 in #7900 (comment)

But I think we should move forward

[ShaMan123]

Background color has been left in for group since the layers in group concept may be slow to enter fabricjs.

Could you explain why Layer will take time to merge into master?
I am fine with dropping background. I have worked around it in my projects.

[ShaMan123]

Please push this

• https://github.com/fabricjs/fabric.js/pull/7900/files#diff-216444c1bc3837d560c8241c4d9643b6de8c147095081c5b38715b9e058c24cbR587
• https://github.com/fabricjs/fabric.js/pull/7900/files#diff-216444c1bc3837d560c8241c4d9643b6de8c147095081c5b38715b9e058c24cbR868

[asturur]

Background color has been left in for group since the layers in group concept may be slow to enter fabricjs.

Could you explain why Layer will take time to merge into master? I am fine with dropping background. I have worked around it in my projects.

Because i have seen the PR, and i don't like the idea of having special logic to allow layers to react to both canvas and group container. I want to simplify things not make more complicated. The layer per se is ok, a dimensionless group always interactive. fine.
the gymmics in the layout management less.
But we can talk there, or maybe we could make an hands on and see how we can make it simpler.

[asturur]

The only large group i know of is the spray brush, can you think of others?
maybe the spray brush shouldn't be a group with thons of rect or circles, it should be just a function able to render a spray effect.

[ShaMan123]

I guess you are right. I don't use huge groups in my projects.

[ShaMan123]

This next? Don't forget my review

[github-actions]

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.07 |    76.01 |    85.7 |   82.79 |                                               
 fabric.js |   83.07 |    76.01 |    85.7 |   82.79 | ...,30881,30955,30966-31031,31154,31253,31489 
-----------|---------|----------|---------|---------|-----------------------------------------------

[asturur]

Applied fixes and merging

[ShaMan123]

What about insertAt - we should filter that as well

[ShaMan123]

so we should only warn now, right?