Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Group): patch #7916 #8000

Merged
merged 10 commits into from
Jun 16, 2022
Merged

fix(Group): patch #7916 #8000

merged 10 commits into from
Jun 16, 2022

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Jun 10, 2022 •
edited
Loading

Hopefully this is all we missed out in #7916 .
Resolves #7916 (review)

@ShaMan123 ShaMan123 requested a review from asturur June 10, 2022 16:32
@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.11 |    76.06 |   85.71 |   82.83 |                                               
 fabric.js |   83.11 |    76.06 |   85.71 |   82.83 | ...,30892,30966,30977-31042,31165,31264,31500 
-----------|---------|----------|---------|---------|-----------------------------------------------

ShaMan123
ShaMan123 commented Jun 10, 2022
View reviewed changes
Copy link
Contributor Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready

@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.11 |    76.06 |   85.71 |   82.83 |                                               
 fabric.js |   83.11 |    76.06 |   85.71 |   82.83 | ...,30892,30966,30977-31042,31165,31264,31500 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123 ShaMan123 added the v6 label Jun 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.12 |    76.05 |   85.77 |   82.85 |                                               
 fabric.js |   83.12 |    76.05 |   85.77 |   82.85 | ...,30871,30945,30956-31021,31144,31243,31479 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123
fix(): dereference canvas
bbb4288 
 dereference canvas before firing `removed` event
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.11 |    76.02 |   85.77 |   82.84 |                                               
 fabric.js |   83.11 |    76.02 |   85.77 |   82.84 | ...,30871,30945,30956-31021,31144,31243,31479 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123 ShaMan123 mentioned this pull request Jun 13, 2022
Closed
48 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.16 |    76.05 |   85.77 |   82.89 |                                               
 fabric.js |   83.16 |    76.05 |   85.77 |   82.89 | ...,30871,30945,30956-31021,31144,31243,31479 
-----------|---------|----------|---------|---------|-----------------------------------------------

ShaMan123
ShaMan123 commented Jun 15, 2022
View reviewed changes
Copy link
Contributor Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated from master
READY TO MERGE!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    83.2 |    76.13 |   85.77 |   82.93 |                                               
 fabric.js |    83.2 |    76.13 |   85.77 |   82.93 | ...,30862,30936,30947-31012,31135,31234,31470 
-----------|---------|----------|---------|---------|-----------------------------------------------

asturur
asturur reviewed Jun 16, 2022
View reviewed changes
src/static_canvas.class.js
this.fire('object:removed', { target: obj });
obj.fire('removed', { target: this });
obj._set('canvas', undefined);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any bug with removing the canvas before or after?
We could pass a reference to the canvas in the event itself as oldCanvas?
In general what are the reason for this line swap?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7859 (comment)

In terms of design and naming it's removed so I think canvas should not be referenced anymore once the event triggers (this is how group behaves) so it is consistent across fabric

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it is passed as the target

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right this is the canvas not the object. i didn't think of it.

@asturur asturur merged commit 8705f61 into master Jun 16, 2022
@ShaMan123 ShaMan123 deleted the v6-group-fix-#7916 branch September 11, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur asturur approved these changes

Assignees
No one assigned
Labels
v6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaMan123 @asturur