Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(): update guides #8189

Merged
merged 144 commits into from
Oct 17, 2022
Merged

docs(): update guides #8189

merged 144 commits into from
Oct 17, 2022

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Aug 26, 2022 •
edited
Loading

READY

  • README rework
  • moved license to a dedicated file
  • moved PR TEMPLATE in hope it will become visible
  • addressed some issues in the bug report template
  • CONTRIBUTING - added some stuff out of wikis
  • GOTCHA.md - consumed relevant stuff from wiki and website, I put it here until we publish a new website. It is a decent guide.
  • bug_report template has been refactored into a form with an action updating versions on release

closes #8281

@ShaMan123 ShaMan123 changed the title Update README.md docs(): Update README.md Aug 26, 2022
@ShaMan123 ShaMan123 added the docs label Aug 26, 2022
@ShaMan123 ShaMan123 changed the title docs(): Update README.md docs(): Update README, ISSUE_TEMPLATE, LICENSE Aug 26, 2022
@ShaMan123 ShaMan123 requested a review from asturur August 26, 2022 14:35
@ShaMan123 ShaMan123 mentioned this pull request Aug 26, 2022
Merged
@ShaMan123 ShaMan123 changed the title docs(): Update README, ISSUE_TEMPLATE, LICENSE docs(): update guides Aug 26, 2022
ShaMan123
ShaMan123 commented Oct 15, 2022
View reviewed changes
Copy link
Contributor Author

@ShaMan123 ShaMan123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged #8281 and added some settings.
done more editing
refactored to use md reference link

@ShaMan123
Copy link
Contributor Author

I am done here

@asturur
Update README.md
4ffff6c 
changed browser support table + small description, changed _competition_ with similar features
asturur
asturur previously approved these changes Oct 15, 2022
View reviewed changes
@ShaMan123 ShaMan123 requested a review from asturur October 15, 2022 23:01
@ShaMan123
Copy link
Contributor Author

I need your approval since I merged master

@ShaMan123 ShaMan123 merged commit 6414077 into master Oct 17, 2022
@ShaMan123 ShaMan123 mentioned this pull request Oct 17, 2022
Merged
ShaMan123 added a commit that referenced this pull request Oct 20, 2022
@ShaMan123 @melchiar
ci(): guides follow up (#8379)
a7e3cbb 
Fix left overs from #8189 

- typos
- links
- add feature request template
- update bug report action to run on master always

Co-authored-by: Steve Eberhardt <melchiar2@gmail.com>
@asturur asturur deleted the readme branch November 1, 2022 23:37
frankrousseau pushed a commit to cgwire/fabric.js that referenced this pull request Jan 6, 2023
@ShaMan123 @github-actions
@melchiar @asturur @frankrousseau
docs(): update guides (fabricjs#8189)
d52e432 

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Steve Eberhardt <melchiar2@gmail.com>
Co-authored-by: Andrea Bogazzi <andreabogazzi79@gmail.com>
frankrousseau pushed a commit to cgwire/fabric.js that referenced this pull request Jan 6, 2023
@ShaMan123 @melchiar @frankrousseau
ci(): guides follow up (fabricjs#8379)
016e924 
Fix left overs from fabricjs#8189 

- typos
- links
- add feature request template
- update bug report action to run on master always

Co-authored-by: Steve Eberhardt <melchiar2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur asturur approved these changes

@melchiar melchiar Awaiting requested review from melchiar

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs(): wiki gotchas link is broken
3 participants
@ShaMan123 @asturur @melchiar