-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(TS): BaseBrush abstract methods #8428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added abstract methods for clarity and ease of development
@@ -100,6 +105,11 @@ export abstract class BaseBrush { | |||
ctx.transform(v[0], v[1], v[2], v[3], v[4], v[5]); | |||
} | |||
|
|||
protected needsFullRender() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved it because it was in between shadow methods
Build Stats
|
/** | ||
* @returns true if brush should continue blocking interaction | ||
*/ | ||
abstract onMouseUp(ev: TBrushEventData): boolean | void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to make all signature the same
abstract onMouseUp(ev: TBrushEventData): boolean | void; | |
abstract onMouseUp(pointer: Point, ev: TBrushEventData): boolean | void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's plan the new api directly.
Motivation
Description
Finalizes #8182
Changes
Gist
In Action