fix(): #9009 artifacts #9022

ShaMan123 · 2023-06-14T07:17:40Z

Motivation

I want this removed because I think in the future it is a potential bug
Once we remove type getter this thing will become an artifact

Originally posted by @ShaMan123 in #9009 (comment)

Description

I did not imagine that would happen so fast.

Changes

Gist

In Action

github-actions · 2023-06-14T07:19:51Z

Build Stats

file / KB (diff)	bundled	minified
fabric	922.922 (+0.040)	303.187 (+0.013)

ShaMan123

Fixes textbox.type and removes future bug potential with the filters.

github-actions · 2023-06-14T07:21:20Z

Coverage after merging fix-9009-artifact into master will be

83.75%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
index.node.ts	7.69%	100%	0%	14.29%	17, 20, 23, 35, 38, 41
src
ClassRegistry.ts	100%	100%	100%	100%
Collection.ts	94.71%	94.64%	86.67%	97.09%	101, 104, 207–208, 233–234
CommonMethods.ts	96.55%	87.50%	100%	100%	10
Intersection.ts	100%	100%	100%	100%
Observable.ts	87.23%	85.29%	84.62%	89.36%	144–145, 170–171, 39–40, 48, 57, 91, 99
Point.ts	100%	100%	100%	100%
Shadow.ts	98.36%	95.65%	100%	100%	178
cache.ts	97.06%	90%	100%	100%	57
config.ts	75%	66.67%	66.67%	82.76%	130, 138, 138, 138, 138, 138–140, 151–153
constants.ts	100%	100%	100%	100%
src/Pattern
Pattern.ts	92.31%	91.89%	90%	93.55%	118, 129, 138, 31, 94
src/brushes
BaseBrush.ts	100%	100%	100%	100%
CircleBrush.ts	0%	0%	0%	0%	108, 108, 108, 110, 112, 114–116, 118–121, 128–129, 136, 138, 23–24, 32–36, 40–44, 51–54, 62–66, 68, 76, 76, 76, 76, 76–77, 79, 79, 79–82, 84, 92–93, 95, 97–99
PatternBrush.ts	97.06%	87.50%	100%	100%	21
PencilBrush.ts	91.01%	82.35%	100%	93.75%	122–123, 152, 152–154, 176, 176, 276, 280, 285–286, 68–69, 84–85
SprayBrush.ts	0%	0%	0%	0%	107, 107, 107, 107, 107–108, 110–111, 118–119, 121, 123–127, 136, 140–141, 141, 149, 149, 149–152, 154–157, 161–162, 164, 166–169, 17, 172, 179, 18, 180, 182, 184–185, 187, 194–195, 197–198, 20, 201, 201, 208, 208, 21, 212, 22, 22, 22–24, 28, 37, 44, 51, 58, 65, 84–86, 94–96, 98–99
src/canvas
Canvas.ts	79.05%	77.54%	83.05%	79.57%	1000–1001, 1001, 1001–1003, 1005–1006, 1006, 1006, 1008, 1016, 1016, 1016–1018, 1018, 1018, 1024–1025, 1033–1034, 1034, 1034–1035, 1040, 1042, 1073–1075, 1078–1079, 1083–1084, 1197–1199, 1202–1203, 1276, 1395, 1515, 161, 186, 296–297, 300–304, 309, 332–333, 338–343, 36, 363, 363, 363–364, 364, 364–365, 373, 378–379, 379, 379–380, 382, 391, 397–398, 398, 398, 40, 441, 449, 453, 453, 453–454, 456, 538–539, 539, 539–540, 546, 546, 546–548, 568, 570, 570, 570–571, 571, 571, 574, 574, 574–575, 578, 587–588, 590–591, 593, 593–594, 596–597, 609–610, 610, 610–611, 613–618, 624, 631, 668, 668, 668, 670, 672–677, 683, 689, 689, 689–690, 692, 695, 700, 713, 741, 741, 799–800, 800, 800–801, 803, 806–807, 807, 807–808, 810–811, 814, 814–816, 819–820, 890, 902, 909, 930, 962, 983–984
SelectableCanvas.ts	94.42%	92.24%	94.23%	96.15%	1115, 1115–1116, 1119, 1139, 1139, 1188, 1196, 1315, 1317, 1319–1320, 519, 694–695, 697–698, 698, 698, 747–748, 809–810, 863–865, 897, 902–903, 930–931
StaticCanvas.ts	96.73%	92.88%	100%	98.52%	1037–1038, 1038, 1038–1039, 1159, 1169, 1223–1224, 1227, 1262–1263, 1339, 1348, 1348, 1352, 1352, 1399–1400, 309–310, 326, 694, 706–707
TextEditingManager.ts	84.31%	71.43%	91.67%	88%	17–18, 18, 18–19, 19, 19
src/canvas/DOMManagers
CanvasDOMManager.ts	95.52%	70%	100%	100%	21–22, 29
StaticCanvasDOMManager.ts	100%	100%	100%	100%
util.ts	86.67%	80.56%	83.33%	93.94%	14, 26, 63–64, 67, 67, 74, 93–94
src/color
Color.ts	94.96%	91.67%	96.30%	96.05%	233, 258–259, 267–268, 48
color_map.ts	100%	100%	100%	100%
constants.ts	100%	100%	100%	100%
util.ts	85.71%	76.92%	100%	89.74%	55–56, 56, 58, 58, 58–59, 61–62, 89
src/controls
Control.ts	93.33%	87.88%	91.67%	97.78%	175, 240, 327, 327, 362
changeWidth.ts	100%	100%	100%	100%
commonControls.ts	100%	100%	100%	100%
controlRendering.ts	81.63%	78%	100%	84.78%	106, 111, 121, 121, 45, 50, 61, 61, 65–72, 81–82
drag.ts	100%	100%	100%	100%
fireEvent.ts	88.89%	75%	100%	100%	13
polyControl.ts	5.97%	0%	0%	11.11%	100, 105, 119, 119, 119, 119, 119, 121–124, 124, 127, 134, 17, 25–29, 29, 29, 29, 29, 29, 29, 29, 50–56, 56, 56, 56, 56, 58, 63–64, 66, 76, 82–83, 83, 83–84, 88–90, 90, 90, 90, 90, 92
rotate.ts	19.57%	12.50%	50%	21.43%	41, 45, 51, 51, 51–52, 55–57, 59, 59, 59, 59, 59–61, 61, 61–63, 65, 65, 65–67, 67, 67–68, 73, 73, 73–74, 76, 78, 80–81
scale.ts	93.57%	92.94%	100%	93.67%	129–130, 132–134, 148–149, 181–183, 42
scaleSkew.ts	78.79%	64.29%	100%	85.71%	27, 29, 29, 29, 31, 33, 35
skew.ts	91.03%	79.31%	100%	97.67%	131–132, 163–164, 171, 177, 179
util.ts	100%	100%	100%	100%
wrapWithFireEvent.ts	100%	100%	100%	100%
wrapWithFixedAnchor.ts	100%	100%	100%	100%
src/env
browser.ts	84.21%	77.78%	50%	100%	14, 17
index.ts	100%	100%	100%	100%
node.ts	74.07%	33.33%	66.67%	88.89%

asturur · 2023-06-15T00:55:06Z

mmmmm
those get type are there for backaward compat?
What is the bug actually?

ShaMan123 · 2023-06-15T01:49:10Z

The bug is textbox.type==='i-text'
Filters have a grtter from super class, enogh just to set static type

asturur · 2023-06-15T08:02:22Z

in fabric6 instances need to have a type property that return the fabric 5 style type.
We stopped using internally and we will remove if forward in time.
That `i-text' is on purpose.

asturur · 2023-06-15T08:03:34Z

src/filters/ColorMatrixFilters.ts

@@ -3,10 +3,6 @@ import { classRegistry } from '../ClassRegistry';

 export function createColorMatrixFilter(key: string, matrix: number[]) {
  const newClass = class extends ColorMatrix {
-    get type() {
-      return key;
-    }


if this still works because of BaseFilter, this we can remove

asturur · 2023-06-15T08:03:44Z

src/shapes/IText/IText.ts

@@ -204,10 +204,6 @@ export class IText<

  static type = 'IText';

-  get type() {
-    return 'i-text';
-  }


this should stay.

But is breaks subclassing
Textbox is broken

~~We should instead override isType like you did with object~~

Fixed like you did with object

ShaMan123

This is ready and satisfies all requirements

ShaMan123 · 2023-06-16T01:48:21Z

src/shapes/IText/IText.ts

@@ -204,10 +204,6 @@ export class IText<

  static type = 'IText';

-  get type() {
-    return 'i-text';
-  }


Fixed like you did with object

ShaMan123 · 2023-06-16T01:48:39Z

.codesandbox/templates/vanilla/src/index.ts

@@ -2,7 +2,7 @@ import * as fabric from 'fabric';
 import './styles.css';

 const el = document.getElementById('canvas');
-const canvas = new fabric.Canvas(el);
+const canvas = (window.canvas = new fabric.Canvas(el));


for ease of dev

fix(): #9009 artifacts

9fd54f0

ShaMan123 requested a review from asturur June 14, 2023 07:17

github-actions bot and others added 2 commits June 14, 2023 07:18

update CHANGELOG.md

24bcbef

Update CHANGELOG.md

bf4ec33

ShaMan123 commented Jun 14, 2023

View reviewed changes

asturur reviewed Jun 15, 2023

View reviewed changes

ShaMan123 added 3 commits June 16, 2023 10:43

Merge branch 'master' into fix-9009-artifact

93693ea

Update IText.ts

2fb222f

Update index.ts

67c68ab

ShaMan123 commented Jun 16, 2023

View reviewed changes

ShaMan123 requested a review from asturur June 16, 2023 01:50

asturur previously approved these changes Jul 1, 2023

View reviewed changes

Merge branch 'master' into fix-9009-artifact

f8b612f

asturur dismissed their stale review via f8b612f July 1, 2023 21:28

asturur approved these changes Jul 1, 2023

View reviewed changes

asturur merged commit 42b8259 into master Jul 1, 2023

asturur deleted the fix-9009-artifact branch July 1, 2023 21:28

asturur mentioned this pull request Aug 18, 2023

chore(): bump to 6.0.0-beta11 #9162

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(): #9009 artifacts #9022

fix(): #9009 artifacts #9022

ShaMan123 commented Jun 14, 2023

github-actions bot commented Jun 14, 2023 •

edited

Loading

ShaMan123 left a comment •

edited

Loading

github-actions bot commented Jun 14, 2023 •

edited

Loading

asturur commented Jun 15, 2023

ShaMan123 commented Jun 15, 2023

asturur commented Jun 15, 2023

asturur Jun 15, 2023

asturur Jun 15, 2023

ShaMan123 Jun 15, 2023

ShaMan123 Jun 15, 2023 •

edited

Loading

ShaMan123 Jun 16, 2023

ShaMan123 left a comment •

edited

Loading

ShaMan123 Jun 16, 2023

ShaMan123 Jun 16, 2023

fix(): #9009 artifacts #9022

fix(): #9009 artifacts #9022

Conversation

ShaMan123 commented Jun 14, 2023

Motivation

Description

Changes

Gist

In Action

github-actions bot commented Jun 14, 2023 • edited Loading

ShaMan123 left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jun 14, 2023 • edited Loading

asturur commented Jun 15, 2023

ShaMan123 commented Jun 15, 2023

asturur commented Jun 15, 2023

asturur Jun 15, 2023

Choose a reason for hiding this comment

asturur Jun 15, 2023

Choose a reason for hiding this comment

ShaMan123 Jun 15, 2023

Choose a reason for hiding this comment

ShaMan123 Jun 15, 2023 • edited Loading

Choose a reason for hiding this comment

ShaMan123 Jun 16, 2023

Choose a reason for hiding this comment

ShaMan123 left a comment • edited Loading

Choose a reason for hiding this comment

ShaMan123 Jun 16, 2023

Choose a reason for hiding this comment

ShaMan123 Jun 16, 2023

Choose a reason for hiding this comment

github-actions bot commented Jun 14, 2023 •

edited

Loading

ShaMan123 left a comment •

edited

Loading

github-actions bot commented Jun 14, 2023 •

edited

Loading

ShaMan123 Jun 15, 2023 •

edited

Loading

ShaMan123 left a comment •

edited

Loading