-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(): #9009 artifacts #9022
fix(): #9009 artifacts #9022
Changes from all commits
9fd54f0
24bcbef
bf4ec33
93693ea
2fb222f
67c68ab
f8b612f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,10 +3,6 @@ import { classRegistry } from '../ClassRegistry'; | |
|
||
export function createColorMatrixFilter(key: string, matrix: number[]) { | ||
const newClass = class extends ColorMatrix { | ||
get type() { | ||
return key; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if this still works because of BaseFilter, this we can remove |
||
|
||
static type = key; | ||
|
||
static defaults = { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -205,7 +205,9 @@ export class IText< | |
static type = 'IText'; | ||
|
||
get type() { | ||
return 'i-text'; | ||
const type = super.type; | ||
// backward compatibility | ||
return type === 'itext' ? 'i-text' : type; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this should stay. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But is breaks subclassing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed like you did with object |
||
|
||
/** | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for ease of dev