Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Python >3.9 & update workflows to use 3.9 & 3.10 #1744

Closed
wants to merge 9 commits into from

Conversation

saitcakmak
Copy link
Contributor

@saitcakmak saitcakmak commented Jul 25, 2023

Follow up to pytorch/botorch#1924 to avoid CI failures.

NOTE: We cannot support 3.11 currently due to a failure in torchx tests. See pytorch/torchx#744

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 25, 2023
README.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (204f589) 94.39% compared to head (b7de553) 94.38%.
Report is 1 commits behind head on main.

❗ Current head b7de553 differs from pull request most recent head dce06e1. Consider uploading reports for the commit dce06e1 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1744      +/-   ##
==========================================
- Coverage   94.39%   94.38%   -0.02%     
==========================================
  Files         454      454              
  Lines       42445    42457      +12     
==========================================
+ Hits        40064    40071       +7     
- Misses       2381     2386       +5     
Files Changed Coverage Δ
...otorch_modular/input_constructors/covar_modules.py 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saitcakmak saitcakmak changed the title Require Python >3.9 & update workflows to use 3.9 & 3.11 Require Python >3.9 & update workflows to use 3.9 & 3.10 Jul 25, 2023
@facebook-github-bot
Copy link
Contributor

@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@esantorella esantorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@facebook-github-bot
Copy link
Contributor

@saitcakmak merged this pull request in 114943e.

@saitcakmak saitcakmak deleted the saitcakmak-patch-3 branch September 7, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants