Don't allow unused **kwargs in input_constructors except for a defined set of exceptions #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1772 +/- ##
==========================================
+ Coverage 94.49% 94.55% +0.06%
==========================================
Files 454 454
Lines 42625 42643 +18
==========================================
+ Hits 40279 40322 +43
+ Misses 2346 2321 -25
☔ View full report in Codecov by Sentry. |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 9, 2023
…d set of exceptions (pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 62bdc6d4d998d5d0f483210889750de00114fbe6
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 9, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 4407a32b94ff51db28e2b625188eea2fd89c1e71
esantorella
force-pushed
the
export-D46519588
branch
from
32f6b24
to
e70b54f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 9, 2023
…d set of exceptions (pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 9120903061b156639395883090919cab2da1bced
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 9, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 44c5c6e99a4e3ae3b287da9901a9e20af322239e
esantorella
force-pushed
the
export-D46519588
branch
from
e70b54f
to
6ed7963
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 11, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 44ea95d82cd50a3ecebc248759ea5d1db9a3bf51
esantorella
force-pushed
the
export-D46519588
branch
from
6ed7963
to
5ac79cc
Compare
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 11, 2023
…d set of exceptions (pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 0e98cee62e4034c17dd2eac794d20550736c5245
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 11, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 10906b5eb68dbd1d83e1775c2cceaa7fa2043a90
esantorella
force-pushed
the
export-D46519588
branch
from
5ac79cc
to
130c639
Compare
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 11, 2023
…d set of exceptions (pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: f876920e8d8fd57144be72fd747d31be7e7eaaa3
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 11, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 738b537d3fcf5b0a204338792a40e5970766f432
esantorella
force-pushed
the
export-D46519588
branch
from
130c639
to
44f96f0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 11, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 961531c8e66c7ec20e94a61ef5f5dd7578b98693
esantorella
force-pushed
the
export-D46519588
branch
from
44f96f0
to
1d873ba
Compare
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 11, 2023
…d set of exceptions (pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 9ae23f426dd94ad88b471d087636b34841bfa79d
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 11, 2023
…d set of exceptions (pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 292966b79d826f987917d7096ff06d316b3efa59
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 15, 2023
…d set of exceptions (pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 47819bc52f37d287408fd985540dd05d58ed1a48
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 15, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 4954b0cf76003492639b98419675a17dc67db49b
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 16, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: lena-kashtelyan Differential Revision: D46519588 fbshipit-source-id: 2870b074becf102f712a3380b316dfe037cd9bdc
esantorella
force-pushed
the
export-D46519588
branch
from
78bf03b
to
938a218
Compare
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 16, 2023
…d set of exceptions (pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 325e41bb0e2b2be501403fdb039d22f3ef91e11b
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 16, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 15e0249c1d6e06f57b24926969b8859e071efe14
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 16, 2023
…d set of exceptions (pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 8b6dfddd8044eb14f6b06dc09d039ddfb4282380
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 16, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 39c46dbc04c5464d7bb7b2720e91bfca92156c55
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 47d734acb908c2af72b8729a9325befeb0575074
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: c267fc464e0f3dd1d221f3ae13f74c0eb8c7a81f
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: lena-kashtelyan Differential Revision: D46519588 fbshipit-source-id: ef78006e43f2aca6ec94f1bb0126a8842a945345
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: lena-kashtelyan Differential Revision: D46519588 fbshipit-source-id: ebd0acf14dd96e11c87ed85b3fa1963c26f70823
esantorella
force-pushed
the
export-D46519588
branch
from
938a218
to
97a46cb
Compare
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 383954715df45538fda470ecdeb5acdcc9171d18
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 5b295423e549939117fce25547612e48f38c49f3
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 986c242587b418a083dc58360622ddb4cc2842bb
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: lena-kashtelyan Differential Revision: D46519588 fbshipit-source-id: 9396e0c72f235a7adc693c5539a4cd8447943e86
esantorella
force-pushed
the
export-D46519588
branch
from
97a46cb
to
71b75bb
Compare
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: lena-kashtelyan Differential Revision: D46519588 fbshipit-source-id: 862fab3fca2460e04462b4b408b6bc3431baa0ff
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: a8e6c319bd706d532b6d822255f85f9247e0402e
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: lena-kashtelyan Differential Revision: D46519588 fbshipit-source-id: 7a050d71f8a2a9bf75a34dd7fa69c1481d049fe4
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
force-pushed
the
export-D46519588
branch
from
71b75bb
to
22ed008
Compare
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: lena-kashtelyan Differential Revision: D46519588 fbshipit-source-id: 5be2e27d8ccd5f01edef468da10133cfe1f8e03e
facebook-github-bot
pushed a commit
to pytorch/botorch
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: #1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: lena-kashtelyan Differential Revision: D46519588 fbshipit-source-id: 8d727cb991f2899cc9e7ee68da7998e981ca8802
|
This pull request has been merged in 2e0aa9d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/botorch#1872
[x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into
**kwargsand be silently ignored[x] add arguments to some input constructors so they don't need any
**kwargs[x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on
[ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions
Reviewed By: SebastianAment
Differential Revision: D46519588