Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow unused **kwargs in input_constructors except for a defined set of exceptions #1772

Closed
wants to merge 1 commit into from
Closed

Don't allow unused **kwargs in input_constructors except for a defined set of exceptions #1772

wants to merge 1 commit into from

Commits on Aug 17, 2023

  1. Don't allow unused **kwargs in input_constructors except for a define… 

    …d set of exceptions (facebook#1772)

Summary:
Pull Request resolved: facebook#1772

X-link: pytorch/botorch#1872

[x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored
[x] add arguments to some input constructors so they don't need any `**kwargs`
[x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on
[ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions

Reviewed By: lena-kashtelyan

Differential Revision: D46519588

fbshipit-source-id: 7a050d71f8a2a9bf75a34dd7fa69c1481d049fe4
    @esantorella @facebook-github-bot
    esantorella authored and facebook-github-bot committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    22ed008 View commit details
    Browse the repository at this point in the history