Fix warning filters in TestCase, introduce AxParameterWarning #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Apr 22, 2024
Summary: This was previously using `UserWarning` since `BoTorchWarning` were being ignored when `settings.debug` was off. This has since been updated and `BoTorchWarning`s are not ignored by default. All other use cases for this warning already use `InputDataWarning`. Related to facebook/Ax#2389 Differential Revision: D56443417
facebook-github-bot
pushed a commit
to pytorch/botorch
that referenced
this pull request
Apr 23, 2024
Summary: Pull Request resolved: #2304 This was previously using `UserWarning` since `BoTorchWarning` were being ignored when `settings.debug` was off. This has since been updated and `BoTorchWarning`s are not ignored by default. All other use cases for this warning already use `InputDataWarning`. Related to facebook/Ax#2389 Reviewed By: Balandat Differential Revision: D56443417 fbshipit-source-id: 4b3bc1fc9169734d4b708d0c6b214452fc044d72
|
@saitcakmak merged this pull request in 0ea8ef8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These filters were not filtering out warning as expected, due to some regex issues and unnecessary
warnings.resetwarnings()within unit tests.warnings.catch_warningsresets the filters by default, so such calls were unnecessary.Note: The BoTorch dtype warnings are produced both as
InputDataWarning&UserWarning. This is only filtering forInputDataWarning. We can reduce the warnings further by updating it on BoTorch to useInputDataWarning.Test Plan:
Ran some tests locally and checked what warnings are produced.
pytest -ra ax/corenow produces ~250 warnings, down from ~700.test_fully_bayesiannow produces 68 warnings, down from 576.