User InputDataWarning for dtype warnings #2304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This was previously using `UserWarning` since `BoTorchWarning` were being ignored when `settings.debug` was off. This has since been updated and `BoTorchWarning`s are not ignored by default. All other use cases for this warning already use `InputDataWarning`. Related to facebook/Ax#2389 Differential Revision: D56443417
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56443417 |
|
This pull request has been merged in cc9e833. |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
May 1, 2024
Summary: Since pytorch#2304, these warnings use `InputDataWarning`. The current filter does not filter these out: https://github.com/pytorch/botorch/actions/runs/8904363989/job/24453525662 Also audited the test classes to make sure they call `super().setUp()` if they overwrite `setUp`. Differential Revision: D56805187
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
May 1, 2024
Summary: Since pytorch#2304, these warnings use `InputDataWarning`. The current filter does not filter these out: https://github.com/pytorch/botorch/actions/runs/8904363989/job/24453525662 Also audited the test classes to make sure they call `super().setUp()` if they overwrite `setUp`. Differential Revision: D56805187
facebook-github-bot
pushed a commit
that referenced
this pull request
May 1, 2024
Summary: Since #2304, these warnings use `InputDataWarning`. The current filter does not filter these out: https://github.com/pytorch/botorch/actions/runs/8904363989/job/24453525662 Also audited the test classes to make sure they call `super().setUp()` if they overwrite `setUp`. Reviewed By: Balandat Differential Revision: D56805187 fbshipit-source-id: a0899a7b799f4cbee13f9b5dff7f36b00bf01c19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This was previously using
UserWarningsinceBoTorchWarningwere being ignored whensettings.debugwas off. This has since been updated andBoTorchWarnings are not ignored by default. All other use cases for this warning already useInputDataWarning.Related to facebook/Ax#2389
Differential Revision: D56443417