Add validation of transition edges to GS #2454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acebook#2428) Summary: This diff enables multiple nodes to be used to generate a single batch trial. Right now the limitations are that: (1) currently each node only contributes 1 gr to the trial -- we will extend this to n grs in a future diff To do this we added: (1) should_move_trials method (2) updates to the transition criterion args Reviewed By: saitcakmak, lena-kashtelyan Differential Revision: D56743651
Summary: Installed a spell checker and fixed all remaining spelling errors in generation strategy files (gs, generation node, tests, transition criterion) Differential Revision: D57175357
Summary: In a previous diff we decided to add validation that continue_trial_generation flag is the same for all tc that define an edge --> if these are different the gs would have conflicting information how to proceed with generation, and it would be malformed. Also removing the transition_to optional arg is on the todo list - it requires first reworking the MaxGenerationParallelism criterion, which is why i'm doing this first. Reviewed By: saitcakmak Differential Revision: D57248708
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57248708 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2454 +/- ##
==========================================
- Coverage 95.31% 95.31% -0.01%
==========================================
Files 496 496
Lines 48301 48326 +25
==========================================
+ Hits 46040 46063 +23
- Misses 2261 2263 +2 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in c6efba8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In a previous diff we decided to add validation that continue_trial_generation flag is the same for all tc that define an edge --> if these are different the gs would have conflicting information how to proceed with generation, and it would be malformed.
Also removing the transition_to optional arg is on the todo list - it requires first reworking the MaxGenerationParallelism criterion, which is why i'm doing this first.
Reviewed By: saitcakmak
Differential Revision: D57248708