Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation of transition edges to GS #2454

Closed
wants to merge 3 commits into from
Closed

Add validation of transition edges to GS #2454

wants to merge 3 commits into from

Commits on May 14, 2024

  1. model <> node 4/n: Support multiple node generation for single trial (f… 

    …acebook#2428)

Summary:

This diff enables multiple nodes to be used to generate a single batch trial. Right now the limitations are that: 
(1) currently each node only contributes 1 gr to the trial -- we will extend this to n grs in a future diff 

To do this we added:
(1) should_move_trials method
(2) updates to the transition criterion args

Reviewed By: saitcakmak, lena-kashtelyan

Differential Revision: D56743651
    @mgarrard @facebook-github-bot
    mgarrard authored and facebook-github-bot committed May 14, 2024
    Configuration menu
    Copy the full SHA
    e500e77 View commit details
    Browse the repository at this point in the history

  2. fix various spelling errors in gs stack (facebook#2448) 

    Summary:

Installed a spell checker and fixed all remaining spelling errors in generation strategy files (gs, generation node, tests, transition criterion)

Differential Revision: D57175357
    @mgarrard @facebook-github-bot
    mgarrard authored and facebook-github-bot committed May 14, 2024
    Configuration menu
    Copy the full SHA
    740f35e View commit details
    Browse the repository at this point in the history

  3. Add validation of transition edges to GS 

    Summary:
In a previous diff we decided to add validation that continue_trial_generation flag is the same for all tc that define an edge --> if these are different the gs would have conflicting information how to proceed with generation, and it would be malformed.

Also removing the transition_to optional arg is on the todo list - it requires first reworking the MaxGenerationParallelism criterion, which is why i'm doing this first.

Reviewed By: saitcakmak

Differential Revision: D57248708
    @mgarrard @facebook-github-bot
    mgarrard authored and facebook-github-bot committed May 14, 2024
    Configuration menu
    Copy the full SHA
    33ac2c4 View commit details
    Browse the repository at this point in the history