Clean up factory functions for legacy models #2508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The legacy models have been raising deprecation warnings for a while, and the factory functions are generally not recommended and not supported with GS, so we can clean them up. `get_GPEI` is left behind in this diff, since it has some usage & documentation that needs to be cleaned up along with it. Differential Revision: D58316106
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58316106 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2508 +/- ##
==========================================
- Coverage 95.28% 95.21% -0.08%
==========================================
Files 485 485
Lines 47411 47173 -238
==========================================
- Hits 45176 44914 -262
- Misses 2235 2259 +24 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 58d5dd8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The legacy models have been raising deprecation warnings for a while, and the factory functions are generally not recommended and not supported with GS, so we can clean them up.
get_GPEIis left behind in this diff, since it has some usage & documentation that needs to be cleaned up along with it.Differential Revision: D58316106