Allow optimas to run with latest Ax version
#239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 335c08a.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
shuds13
reviewed
Aug 29, 2024
|
Yes, agreed. This is work in progress: the current changes do fix issues with transitioning to the new version, but there are more similar issues that remain to be fixed (hence the failing test). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements several changes in order for
optimasto useax-platform 0.4.1.A number of changes were indeed introduced between
ax-platform 0.4.1andax-platform 0.4.0:register_metricwas removed in this PR: Delete register_metric and remove default metric from register_metrics facebook/Ax#2560. Inoptimaswe now useregister_metricsinstead ofregister_metric.get_MTGP_LEGACYwas removed in this PR: Clean up factory functions for legacy models facebook/Ax#2508. We now recreate this function inoptimasfor compatibility._maybe_move_to_next_stepwas renamed as_maybe_transition_to_next_nodein this PR: fix various spelling errors in gs stack facebook/Ax#2448. We now use_maybe_transition_to_next_nodeinoptimas.