Remove unnecessary wrapper-helper around early-stopping call #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55710758 |
|
This pull request was exported from Phabricator. Differential Revision: D55710758 |
lena-kashtelyan
force-pushed
the
export-D55710758
branch
from
69bdc4b
to
7c6e286
Compare
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Aug 16, 2024
…k#2666) Summary: Pull Request resolved: facebook#2666 As titled Differential Revision: D55710758
|
This pull request was exported from Phabricator. Differential Revision: D55710758 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Aug 16, 2024
…k#2666) Summary: Pull Request resolved: facebook#2666 As titled Differential Revision: D55710758
lena-kashtelyan
force-pushed
the
export-D55710758
branch
from
7c6e286
to
3d00eb2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55710758 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Aug 16, 2024
…k#2666) Summary: Pull Request resolved: facebook#2666 As titled Differential Revision: D55710758
lena-kashtelyan
force-pushed
the
export-D55710758
branch
from
3d00eb2
to
3cab75a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55710758 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Aug 16, 2024
…k#2666) Summary: Pull Request resolved: facebook#2666 As titled Differential Revision: D55710758
lena-kashtelyan
force-pushed
the
export-D55710758
branch
from
3cab75a
to
5bfdb10
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55710758 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Aug 16, 2024
…k#2666) Summary: Pull Request resolved: facebook#2666 As titled Differential Revision: D55710758
lena-kashtelyan
force-pushed
the
export-D55710758
branch
from
5bfdb10
to
7e36810
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55710758 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Aug 16, 2024
…k#2666) Summary: Pull Request resolved: facebook#2666 As titled Differential Revision: D55710758
lena-kashtelyan
force-pushed
the
export-D55710758
branch
from
7e36810
to
df9f59b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55710758 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Sep 5, 2024
…k#2666) Summary: Pull Request resolved: facebook#2666 As titled Reviewed By: saitcakmak, Balandat Differential Revision: D55710758
lena-kashtelyan
force-pushed
the
export-D55710758
branch
from
df9f59b
to
c340084
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55710758 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Sep 6, 2024
…k#2666) Summary: Pull Request resolved: facebook#2666 As titled Reviewed By: saitcakmak, Balandat Differential Revision: D55710758
lena-kashtelyan
force-pushed
the
export-D55710758
branch
from
c340084
to
007c4ef
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55710758 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Sep 10, 2024
…k#2666) Summary: Pull Request resolved: facebook#2666 As titled Reviewed By: saitcakmak, Balandat Differential Revision: D55710758
lena-kashtelyan
force-pushed
the
export-D55710758
branch
from
007c4ef
to
eaf5675
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55710758 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Sep 10, 2024
…k#2666) Summary: Pull Request resolved: facebook#2666 As titled Reviewed By: saitcakmak, Balandat Differential Revision: D55710758
lena-kashtelyan
force-pushed
the
export-D55710758
branch
from
eaf5675
to
72371c6
Compare
…k#2666) Summary: Pull Request resolved: facebook#2666 As titled Reviewed By: saitcakmak, Balandat Differential Revision: D55710758
|
This pull request was exported from Phabricator. Differential Revision: D55710758 |
lena-kashtelyan
force-pushed
the
export-D55710758
branch
from
72371c6
to
2f1d3fc
Compare
|
This pull request has been merged in a4a97d6. |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Sep 16, 2024
…at was timing out the CI Summary: The `EarlyStopsInsteadOfNormalCompletionScheduler` test class was overwriting `should_stop_trials_early`, which was being used to make the early stopping decisions prior to facebook#2666. After that diff, the overwrite became a no-op, leading to this test hanging out and failing the CI. Reviewed By: danielcohenlive, mpolson64 Differential Revision: D62784565
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
…at was timing out the CI (#2770) Summary: Pull Request resolved: #2770 The `EarlyStopsInsteadOfNormalCompletionScheduler` test class was overwriting `should_stop_trials_early`, which was being used to make the early stopping decisions prior to #2666. After that diff, the overwrite became a no-op, leading to this test hanging out and failing the CI. Reviewed By: danielcohenlive, mpolson64 Differential Revision: D62784565 fbshipit-source-id: 11e3b6be0057e82afd82b706aeda54af686a7c8b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled
Differential Revision: D55710758