Fix Scheduler test_run_trials_and_yield_results_with_early_stopper that was timing out the CI #2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at was timing out the CI Summary: The `EarlyStopsInsteadOfNormalCompletionScheduler` test class was overwriting `should_stop_trials_early`, which was being used to make the early stopping decisions prior to facebook#2666. After that diff, the overwrite became a no-op, leading to this test hanging out and failing the CI. Reviewed By: danielcohenlive, mpolson64 Differential Revision: D62784565
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62784565 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2770 +/- ##
==========================================
+ Coverage 95.60% 95.67% +0.07%
==========================================
Files 489 486 -3
Lines 47903 47707 -196
==========================================
- Hits 45796 45643 -153
+ Misses 2107 2064 -43 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in ef4111f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The
EarlyStopsInsteadOfNormalCompletionSchedulertest class was overwritingshould_stop_trials_early, which was being used to make the early stopping decisions prior to #2666. After that diff, the overwrite became a no-op, leading to this test hanging out and failing the CI.Reviewed By: danielcohenlive, mpolson64
Differential Revision: D62784565