Updating failure rate message and accounting #2723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61914570 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2723 +/- ##
=======================================
Coverage 95.40% 95.40%
=======================================
Files 490 490
Lines 47824 47828 +4
=======================================
+ Hits 45627 45631 +4
Misses 2197 2197 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D61914570 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Aug 28, 2024
Summary: Pull Request resolved: facebook#2723 This diff adds a clarification to failure-rate-exceeded errors that "abandoned" trials are also added in the failure rate accounting, which can help users look this up on their own. In addition the diff changes the denominator of the failure-rate computation to only consider trials with a `terminal` status. Differential Revision: D61914570
SebastianAment
force-pushed
the
export-D61914570
branch
from
1fd6c2c
to
560a650
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61914570 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Aug 28, 2024
Summary: Pull Request resolved: facebook#2723 This diff adds a clarification to failure-rate-exceeded errors that "abandoned" trials are also added in the failure rate accounting, which can help users look this up on their own. In addition the diff changes the denominator of the failure-rate computation to only consider trials with a `terminal` status. Differential Revision: D61914570
SebastianAment
force-pushed
the
export-D61914570
branch
from
560a650
to
162bca3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61914570 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Aug 28, 2024
Summary: Pull Request resolved: facebook#2723 This diff adds a clarification to failure-rate-exceeded errors that "abandoned" trials are also added in the failure rate accounting, which can help users look this up on their own. In addition the diff changes the denominator of the failure-rate computation to only consider trials with a `terminal` status. Differential Revision: D61914570
SebastianAment
force-pushed
the
export-D61914570
branch
from
162bca3
to
031f247
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61914570 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Aug 28, 2024
Summary: Pull Request resolved: facebook#2723 This diff adds a clarification to failure-rate-exceeded errors that "abandoned" trials are also added in the failure rate accounting, which can help users look this up on their own. In addition the diff changes the denominator of the failure-rate computation to only consider trials with a `terminal` status. Differential Revision: D61914570
SebastianAment
force-pushed
the
export-D61914570
branch
from
031f247
to
8461e5c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61914570 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Aug 29, 2024
Summary: Pull Request resolved: facebook#2723 This diff adds a clarification to failure-rate-exceeded errors that "abandoned" trials are also added in the failure rate accounting, which can help users look this up on their own. In addition the diff changes the denominator of the failure-rate computation to only consider trials with a `terminal` status. Reviewed By: bernardbeckerman Differential Revision: D61914570
SebastianAment
force-pushed
the
export-D61914570
branch
from
8461e5c
to
3792440
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61914570 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Aug 29, 2024
Summary: Pull Request resolved: facebook#2723 This diff adds a clarification to failure-rate-exceeded errors that "abandoned" trials are also added in the failure rate accounting, which can help users look this up on their own. In addition the diff changes the denominator of the failure-rate computation to only consider trials with a `terminal` status. Reviewed By: bernardbeckerman Differential Revision: D61914570
SebastianAment
force-pushed
the
export-D61914570
branch
from
3792440
to
ecffd91
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61914570 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Aug 29, 2024
Summary: Pull Request resolved: facebook#2723 This diff adds a clarification to failure-rate-exceeded errors that "abandoned" trials are also added in the failure rate accounting, which can help users look this up on their own. In addition the diff changes the denominator of the failure-rate computation to only consider trials with a `terminal` status. Reviewed By: bernardbeckerman Differential Revision: D61914570
SebastianAment
force-pushed
the
export-D61914570
branch
from
ecffd91
to
b48c9d5
Compare
Summary: Pull Request resolved: facebook#2723 This diff adds a clarification to failure-rate-exceeded errors that "abandoned" trials are also added in the failure rate accounting, which can help users look this up on their own. In addition the diff changes the denominator of the failure-rate computation to only consider trials with a `terminal` status. Reviewed By: bernardbeckerman Differential Revision: D61914570
|
This pull request was exported from Phabricator. Differential Revision: D61914570 |
SebastianAment
force-pushed
the
export-D61914570
branch
from
b48c9d5
to
0508b18
Compare
|
This pull request has been merged in 5d91216. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds a clarification to failure-rate-exceeded errors that "abandoned" trials are also added in the failure rate accounting, which can help users look this up on their own.
In addition the diff changes the denominator of the failure-rate computation to only consider trials with a
terminalstatus.Differential Revision: D61914570