Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating failure rate message and accounting #2723

Closed
wants to merge 1 commit into from
Closed

Updating failure rate message and accounting #2723

wants to merge 1 commit into from

Commits on Aug 29, 2024

  1. Updating failure rate message and accounting (facebook#2723) 

    Summary:
Pull Request resolved: facebook#2723

This diff adds a clarification to failure-rate-exceeded errors that "abandoned" trials are also added in the failure rate accounting, which can help users look this up on their own.

In addition the diff changes the denominator of the failure-rate computation to only consider  trials with a `terminal` status.

Reviewed By: bernardbeckerman

Differential Revision: D61914570
    @SebastianAment @facebook-github-bot
    SebastianAment authored and facebook-github-bot committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    0508b18 View commit details
    Browse the repository at this point in the history