Add input constructors as optional field on GenerationNode #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62310414 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2754 +/- ##
==========================================
- Coverage 95.67% 95.67% -0.01%
==========================================
Files 486 488 +2
Lines 47713 47757 +44
==========================================
+ Hits 45650 45691 +41
- Misses 2063 2066 +3 ☔ View full report in Codecov by Sentry. |
…t at 9/6/2024, 10:19:43 AM Differential Revision: D62247100
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Sep 23, 2024
…2754) Summary: Pull Request resolved: facebook#2754 This diff adds the input constructors property to GenerationNode and a simple test on the property. Follow up diffs: - add the two additional input constructors - update the transition logic to leverage this - storage --> let's do this once we all like the 3 input constructors - update the input constructors to handle the case where n isn't provided as a kwarg - add test that all cases of input constructors are handled per Liz's suggestion Reviewed By: lena-kashtelyan Differential Revision: D62310414
|
This pull request was exported from Phabricator. Differential Revision: D62310414 |
mgarrard
force-pushed
the
export-D62310414
branch
from
50f510e
to
a232148
Compare
…2754) Summary: Pull Request resolved: facebook#2754 This diff adds the input constructors property to GenerationNode and a simple test on the property. Follow up diffs: - add the two additional input constructors - update the transition logic to leverage this - storage --> let's do this once we all like the 3 input constructors - update the input constructors to handle the case where n isn't provided as a kwarg - add test that all cases of input constructors are handled per Liz's suggestion Reviewed By: lena-kashtelyan Differential Revision: D62310414
|
This pull request was exported from Phabricator. Differential Revision: D62310414 |
mgarrard
force-pushed
the
export-D62310414
branch
from
a232148
to
b9dcc61
Compare
|
This pull request has been merged in 665d9dd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds the input constructors property to GenerationNode and a simple test on the property.
Follow up diffs:
Differential Revision: D62310414