Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add input constructors as optional field on GenerationNode #2754

Closed
wants to merge 2 commits into from
Closed

Add input constructors as optional field on GenerationNode #2754

wants to merge 2 commits into from

Commits on Sep 23, 2024

  1. Input constructor 1, (uncommitted/untracked changes), Temporary Commi… 

    …t at 9/6/2024, 10:19:43 AM

Differential Revision: D62247100
    @facebook-github-bot
    Mia Garrard authored and facebook-github-bot committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    b9cd616 View commit details
    Browse the repository at this point in the history

  2. Add input constructors as optional field on GenerationNode (facebook#… 

    …2754)

Summary:
Pull Request resolved: facebook#2754

This diff adds the input constructors property to GenerationNode and a simple test on the property.

Follow up diffs:
- add the two additional input constructors
- update the transition logic to leverage this
- storage --> let's do this once we all like the 3 input constructors
- update the input constructors to handle the case where n isn't provided as a kwarg
- add test that all cases of input constructors are handled per Liz's suggestion

Reviewed By: lena-kashtelyan

Differential Revision: D62310414
    @mgarrard @facebook-github-bot
    mgarrard authored and facebook-github-bot committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    b9dcc61 View commit details
    Browse the repository at this point in the history