Allow removal of parameters with different values in RemoveFixed transform #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sform Summary: Previously, the `RemoveFixed.transform_observation_features` transform checked that the parameter being removed had the same value as the fixed parameter in the search space used to initialize the transform. This diff removes this check to allow removal of any observation parameter with the same name. This will allow the transform to operate on observations from two similar but non-identical search spaces. Differential Revision: D63322396
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63322396 |
|
This pull request has been merged in 7a0ffb5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, the
RemoveFixed.transform_observation_featurestransform checked that the parameter being removed had the same value as the fixed parameter in the search space used to initialize the transform.This diff removes this check to allow removal of any observation parameter with the same name. This will allow the transform to operate on observations from two similar but non-identical search spaces.
Differential Revision: D63322396