Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow removal of parameters with different values in RemoveFixed transform #2779

Closed
wants to merge 1 commit into from
Closed

Allow removal of parameters with different values in RemoveFixed transform #2779

wants to merge 1 commit into from

Commits on Sep 24, 2024

  1. Allow removal of parameters with different values in RemoveFixed tran… 

    …sform

Summary:
Previously, the `RemoveFixed.transform_observation_features` transform checked that the parameter being removed had the same value as the fixed parameter in the search space used to initialize the transform.
This diff removes this check to allow removal of any observation parameter with the same name. This will allow the transform to operate on observations from two similar but non-identical search spaces.

Differential Revision: D63322396
    @saitcakmak @facebook-github-bot
    saitcakmak authored and facebook-github-bot committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    40db7d5 View commit details
    Browse the repository at this point in the history