Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterization type fixes; use parameters instad of arms where appropriate #2780

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Parameterization type fixes; use parameters instad of arms where appropriate #2780

wants to merge 2 commits into from

Commits on Sep 24, 2024

  1. Make unit tests for mixed integer problems less repetitive 

    Summary:
* Loop over six cases instead of repeating code
* Have a mock wrap the original function so the original function still gets called

Differential Revision: D63326855
    @esantorella @facebook-github-bot
    esantorella authored and facebook-github-bot committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b6d2171 View commit details
    Browse the repository at this point in the history

  2. Parameterization type fixes; use parameters instad of arms where appr… 

    …opriate (facebook#2780)

Summary:
Pull Request resolved: facebook#2780

Sometimes benchmarking code creates Arms from parameters just so they can be passed to a function that expects an Arm but only uses its parameters. This is silly. It's better to just have the function expect parameters.

Also updated some method signatures to use `Mapping` to indicate that they do not mutate the parameterization, which unfortunately creates the need for Pyre-fixmes if they are passed to a function or class such as `Arm` that does not annotate its arguments as immutable.

Differential Revision: D63327381
    @esantorella @facebook-github-bot
    esantorella authored and facebook-github-bot committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0e857c5 View commit details
    Browse the repository at this point in the history