Simplified and optimized logic for calculating per-metric subsampling rate for MapData #3106
+107
−146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66366076 |
ltiao
force-pushed
the
export-D66366076
branch
from
a5bb39a
to
7b4d45b
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 22, 2024
… rate for MapData (facebook#3106) Summary: This refines the logic for calculating per-metric subsampling rates in `MapData.subsample` and incorporates a (probably premature) performance optimization, achieved by utilizing binary search on a sorted list instead of linear search. Differential Revision: D66366076
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 22, 2024
… rate for MapData (facebook#3106) Summary: This refines the logic for calculating per-metric subsampling rates in `MapData.subsample` and incorporates a (probably premature) performance optimization, achieved by utilizing binary search on a sorted list instead of linear search. Differential Revision: D66366076
ltiao
force-pushed
the
export-D66366076
branch
from
7b4d45b
to
88b6d21
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66366076 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66366076 |
ltiao
force-pushed
the
export-D66366076
branch
from
88b6d21
to
d59384c
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 22, 2024
… rate for MapData (facebook#3106) Summary: This refines the logic for calculating per-metric subsampling rates in `MapData.subsample` and incorporates a (probably premature) performance optimization, achieved by utilizing binary search on a sorted list instead of linear search. Differential Revision: D66366076
|
This pull request was exported from Phabricator. Differential Revision: D66366076 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 23, 2024
… rate for MapData (facebook#3106) Summary: This refines the logic for calculating per-metric subsampling rates in `MapData.subsample` and incorporates a (probably premature) performance optimization, achieved by utilizing binary search on a sorted list instead of linear search. Differential Revision: D66366076
ltiao
force-pushed
the
export-D66366076
branch
from
d59384c
to
b7b8491
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66366076 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3106 +/- ##
=======================================
Coverage 95.49% 95.49%
=======================================
Files 504 504
Lines 50404 50398 -6
=======================================
- Hits 48131 48128 -3
+ Misses 2273 2270 -3 ☔ View full report in Codecov by Sentry. |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 25, 2024
… rate for MapData (facebook#3106) Summary: This refines the logic for calculating per-metric subsampling rates in `MapData.subsample` and incorporates a (probably premature) performance optimization, achieved by utilizing binary search on a sorted list instead of linear search. Reviewed By: Balandat Differential Revision: D66366076
ltiao
force-pushed
the
export-D66366076
branch
from
b7b8491
to
73ee8b7
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 26, 2024
… rate for MapData (facebook#3106) Summary: This refines the logic for calculating per-metric subsampling rates in `MapData.subsample` and incorporates a (probably premature) performance optimization, achieved by utilizing binary search on a sorted list instead of linear search. Reviewed By: Balandat Differential Revision: D66366076
|
This pull request was exported from Phabricator. Differential Revision: D66366076 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 26, 2024
… rate for MapData (facebook#3106) Summary: This refines the logic for calculating per-metric subsampling rates in `MapData.subsample` and incorporates a (probably premature) performance optimization, achieved by utilizing binary search on a sorted list instead of linear search. Reviewed By: Balandat Differential Revision: D66366076
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 26, 2024
… rate for MapData (facebook#3106) Summary: Pull Request resolved: facebook#3106 This refines the logic for calculating per-metric subsampling rates in `MapData.subsample` and incorporates a (probably premature) performance optimization, achieved by utilizing binary search on a sorted list instead of linear search. Differential Revision: D66366076
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 27, 2024
… rate for MapData (facebook#3106) Summary: Pull Request resolved: facebook#3106 This refines the logic for calculating per-metric subsampling rates in `MapData.subsample` and incorporates a (probably premature) performance optimization, achieved by utilizing binary search on a sorted list instead of linear search. Differential Revision: D66366076
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 27, 2024
… rate for MapData (facebook#3106) Summary: Pull Request resolved: facebook#3106 This refines the logic for calculating per-metric subsampling rates in `MapData.subsample` and incorporates a (probably premature) performance optimization, achieved by utilizing binary search on a sorted list instead of linear search. Differential Revision: D66366076
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 27, 2024
… rate for MapData (facebook#3106) Summary: This refines the logic for calculating per-metric subsampling rates in `MapData.subsample` and incorporates a (probably premature) performance optimization, achieved by utilizing binary search on a sorted list instead of linear search. Reviewed By: Balandat Differential Revision: D66366076
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 28, 2024
… rate for MapData (facebook#3106) Summary: This refines the logic for calculating per-metric subsampling rates in `MapData.subsample` and incorporates a (probably premature) performance optimization, achieved by utilizing binary search on a sorted list instead of linear search. Reviewed By: Balandat Differential Revision: D66366076
…ta to Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
… rate for MapData (facebook#3106) Summary: This refines the logic for calculating per-metric subsampling rates in `MapData.subsample` and incorporates a (probably premature) performance optimization, achieved by utilizing binary search on a sorted list instead of linear search. Reviewed By: Balandat Differential Revision: D66366076
ltiao
force-pushed
the
export-D66366076
branch
from
73ee8b7
to
7f4519c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66366076 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 28, 2024
… rate for MapData (facebook#3106) Summary: This refines the logic for calculating per-metric subsampling rates in `MapData.subsample` and incorporates a (probably premature) performance optimization, achieved by utilizing binary search on a sorted list instead of linear search. Reviewed By: Balandat Differential Revision: D66366076
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D66366076