Skip to content

Commit

Permalink
Scope hoisting in webpack 4 (#4504)
Browse files Browse the repository at this point in the history
  • Loading branch information
Jack Zhao authored and Timer committed May 24, 2018
1 parent 61c864c commit 581c453
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
2 changes: 0 additions & 2 deletions packages/react-scripts/config/webpack.config.prod.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,6 @@ module.exports = {
.replace(/\\/g, '/'),
},
optimization: {
// webpack-manifest-plugin currently does not play well with ConcatenatedModule
concatenateModules: false,
minimizer: [
new UglifyJsPlugin({
uglifyOptions: {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"dependencies": {
"@babel/plugin-transform-modules-commonjs": "7.0.0-beta.36",
"@babel/polyfill": "7.0.0-beta.36",
"@babel/register": "7.0.0-beta.36",
"@babel/plugin-transform-modules-commonjs": "7.0.0-beta.46",
"@babel/polyfill": "7.0.0-beta.46",
"@babel/register": "7.0.0-beta.46",
"bootstrap": "4.1.0",
"chai": "3.5.0",
"jsdom": "9.8.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-scripts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"url-loader": "1.0.1",
"webpack": "4.8.3",
"webpack-dev-server": "3.1.4",
"webpack-manifest-plugin": "2.0.2",
"webpack-manifest-plugin": "2.0.3",
"whatwg-fetch": "2.0.4"
},
"devDependencies": {
Expand Down

0 comments on commit 581c453

Please sign in to comment.