Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webpack 4 scope hoisting #4504

Merged
merged 3 commits into from
May 24, 2018
Merged

webpack 4 scope hoisting #4504

merged 3 commits into from
May 24, 2018

Conversation

bugzpodder
Copy link

@facebook-github-bot
Copy link

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

@Timer
Copy link
Contributor

Timer commented May 22, 2018

Wow, thanks for following up on this @bugzpodder.

@Timer Timer added this to the 2.0.0 milestone May 22, 2018
@gaearon
Copy link
Contributor

gaearon commented May 22, 2018

@bugzpodder Is CLA form working for you? I can follow up internally if it's broken

@bugzpodder
Copy link
Author

@gaearon it is broken for me, let me try emailing cla@fb.com first. if it doesnt work will let you know.

@gaearon
Copy link
Contributor

gaearon commented May 22, 2018

Thanks

petetnt
petetnt approved these changes May 22, 2018
View reviewed changes
Copy link
Contributor

@petetnt petetnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job with the follow-up!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer Timer merged commit 581c453 into facebook:next May 24, 2018
@gaearon
Copy link
Contributor

gaearon commented May 29, 2018 •
edited
Loading

FYI @bugzpodder you've been very helpful with fixing CI and these follow-ups, and you should get an invite to be collaborator on this repo soon. Please seek consensus with at least one existing maintainer before merging something big or risky but consider this an invitation to fix things that are broken :-)

@petetnt
Copy link
Contributor

petetnt commented May 29, 2018

Awesome, great job @bugzpodder 👍

zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@Timer
Scope hoisting in webpack 4 (facebook#4504)
3fdb4fd
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petetnt petetnt petetnt approved these changes

Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bugzpodder @facebook-github-bot @Timer @gaearon @petetnt