Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update eslint-webpack-plugin@2.4.1 and enable treads in linter #10249

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marvelsrp
Copy link

I have perfomance problem in build. Results diff react-scripts@4.0.1 and react-scripts@3.4.3 in my project:

Default:

  • react-scripts@3.4.3 eslint-loader@3.0.3, cache: true Done in 190.03s.
  • react-scripts@4.0.1 eslint-webpack-plugin@2.4.1, cache: true Done in 369.82s.

Disable cache:

  • react-scripts@3.4.3 eslint-loader@3.0.3, cache: false Done in 101.78s.
  • react-scripts@4.0.1 eslint-webpack-plugin@2.4.1, cache: false Done in 101.98s.

Enable Treads:

  • react-scripts@4.0.1 eslint-webpack-plugin@2.4.1, cache: true, treads: true Done in 106.12s.
  • react-scripts@4.0.1 eslint-webpack-plugin@2.4.1, cache: false, treads: true Done in 84.70s.

I see performance improvement after package update eslint-webpack-plugin to 2.4.1 and enable multi treads linter.

Enable treads

@facebook-github-bot
Copy link

Hi @marvelsrp!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale
Copy link

stale bot commented Jan 9, 2022

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants