Fix slow recompile times for existing users #10265
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9886 was a crippling performance regression that rendered
react-scripts
close to unusable, at least for all my projects where I was using it.Fortunately, this performance regression was fixed by the following release of
eslint-webpack-plugin
: https://github.com/webpack-contrib/eslint-webpack-plugin/releases/tag/v2.4.1 (otherwise I would have been forced to downgrade to react-scripts 3.X).However, the performance regression was only fixed for new users of
react-scripts
, but not for existing users.The problem is that the internal dependency to
eslint-webpack-plugin
still accepts broken versions it its admissible range of versions.Therefore, existing users are forced to read through #9886 until they find out that they either have to manually bump
eslint-webpack-plugin
or delete their entirepackage-lock.json
and re-install everything from scratch.So this PR is an attempt to fix the performance regression for all users that are updating
react-scripts
, instead of waiting until they read through GitHub bug reports or delete their package-lock files.