Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slow recompile times for existing users #10265

Closed
wants to merge 1 commit into from
Closed

Fix slow recompile times for existing users #10265

wants to merge 1 commit into from

Conversation

fkirc
Copy link

@fkirc fkirc commented Dec 18, 2020

#9886 was a crippling performance regression that rendered react-scripts close to unusable, at least for all my projects where I was using it.
Fortunately, this performance regression was fixed by the following release of eslint-webpack-plugin: https://github.com/webpack-contrib/eslint-webpack-plugin/releases/tag/v2.4.1 (otherwise I would have been forced to downgrade to react-scripts 3.X).

However, the performance regression was only fixed for new users of react-scripts, but not for existing users.
The problem is that the internal dependency to eslint-webpack-plugin still accepts broken versions it its admissible range of versions.
Therefore, existing users are forced to read through #9886 until they find out that they either have to manually bump eslint-webpack-plugin or delete their entire package-lock.json and re-install everything from scratch.

So this PR is an attempt to fix the performance regression for all users that are updating react-scripts, instead of waiting until they read through GitHub bug reports or delete their package-lock files.

@facebook-github-bot
Copy link

Hi @fkirc!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@marvelsrp
Copy link

Hello, I have same problem. Update to 2.4.1 don't fix. Need add treads: true flag for upgrade performance eslint.
#10249

@fkirc
Copy link
Author

fkirc commented Jan 5, 2021

Hello, I have same problem. Update to 2.4.1 don't fix. Need add treads: true flag for upgrade performance eslint.
#10249

For me, updating the package-lock to 2.4.1 was sufficient.
But anyways, thank you for filing a second PR; this should increase the chances of getting it fixed.

@stale
Copy link

stale bot commented Jan 9, 2022

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 9, 2022
@Saibamen
Copy link

Saibamen commented Jan 9, 2022

.

@stale stale bot removed the stale label Jan 9, 2022
@fkirc fkirc closed this by deleting the head repository Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants