feat(eslint-config-react-app): support eslint-plugin-testing-library 4.x

[MichaelDeBoey]

eslint-plugin-testing-library v4.0.0 is released 🎉

I updated the ruleset to the recommended react ruleset as can be seen at https://github.com/testing-library/eslint-plugin-testing-library/blob/2a92133b467e749cc4a8b2a95c9fdac76d7f4ca7/lib/index.ts#L72-L79

I also updated all other ESLint related dependencies to latest minor

---

CC/ @Belco90

[Belco90]

I'd suggest just bumping eslint-plugin-testing-library to v4 without enabling/updating any rule error level. Otherwise, it will be an actual breaking change update. If we just bump the plugin to v4 without changing any of the currently enabled rules, it shouldn't be a major one since those rules would work in the same way, just reporting some extra edge cases not handled properly before.

[MichaelDeBoey]

I sure can split this PR into bumping the version and creating another (breaking) PR to update the ruleset, which can then be included in v5.

CC/ @ianschmitz

[aruniverse]

I'd like to bump this pr. Updating the version of eslint-plugin-testing-library to ^4.9.0 throughout the monorepo should be good enough, the version of @typescript-eslint/* packages will all resolve to the same ver

[Belco90]

I'd like to bump this pr. Updating the version of eslint-plugin-testing-library to ^4.9.0 throughout the monorepo should be good enough, the version of @typescript-eslint/* packages will all resolve to the same ver

Yes, that would be amazing. Also, as mentioned before, I think we should only update eslint-plugin-testing-library without enabling more rules since that would introduce breaking changes. @MichaelDeBoey are you available to do those changes? If not I can generate an alternative PR, but better to reuse yours.

[Belco90]

Thank you @MichaelDeBoey 🎉

[aruniverse]

should be fine bumping other deps, but not sure its necessary/mandatory since theyre all using ^ and should pull in the latest anyway

[karlhorky]

This can be closed now, I'm assuming?

Because eslint-plugin-testing-library is now at ^5.0.1:

create-react-app/packages/eslint-config-react-app/package.json

Line 36 in 221e511

"eslint-plugin-testing-library": "^5.0.1"

[Belco90]

Indeed, it can be closed now.