Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[babel-preset-react-app] Temporary fix missing babel plugins #1177

Merged
merged 2 commits into from
Dec 6, 2016
Merged

[babel-preset-react-app] Temporary fix missing babel plugins #1177

merged 2 commits into from
Dec 6, 2016

Conversation

EnoahNetzach
Copy link
Contributor

As said in #1156 and #1160 it seems that babel-plugin-transform-regenerator needs some additional plugins to work, and babel-preset-env is unable to detect it.

@gaearon
Copy link
Contributor

gaearon commented Dec 6, 2016

Does this fix your tests?

@gaearon gaearon added this to the 0.8.2 milestone Dec 6, 2016
@EnoahNetzach
Copy link
Contributor Author

Yes, all of them

@gaearon
Copy link
Contributor

gaearon commented Dec 6, 2016

k let's do it.
I think this is also a good time to set up some integration tests.

There was an attempt in #875 but the submitter didn't follow up and I'm not sure how to best solve this. Would you like to take over that PR and figure out a good way to integrate it?

@gaearon gaearon merged commit 7af5374 into facebook:master Dec 6, 2016
@EnoahNetzach
Copy link
Contributor Author

Yes, I was thinking about some more accurate tests, maybe in the template in react-scripts.
Maybe it could also be useful for showcasing what can be done with es6..

@gaearon
Copy link
Contributor

gaearon commented Dec 6, 2016

I'd rather keep the default template simple and only use those for catching regressions.

@gaearon
Copy link
Contributor

gaearon commented Dec 6, 2016

Bonus points: have a way to actually assert things in such integration tests. Not just run npm start and npm run build but execute the produced bundle in jsdom so that we can make assertions inside of it.

@EnoahNetzach
Copy link
Contributor Author

That's also an option, and we could also address the problem with using npm link with react-scripts (I'll open an issue, but I talked about it here #936)

@EnoahNetzach EnoahNetzach deleted the missing-babel-plugins branch December 6, 2016 13:58
@EnoahNetzach EnoahNetzach mentioned this pull request Dec 6, 2016
Closed
@gaearon gaearon mentioned this pull request Dec 6, 2016
Merged
EnoahNetzach added a commit to EnoahNetzach/create-react-app that referenced this pull request Dec 6, 2016
@EnoahNetzach
[babel-preset-react-app] Temporary fix missing babel plugins (faceboo…
5caa05d 
…k#1177)

* temporary fix missing babel plugins

* Add an issue link
@EnoahNetzach
Copy link
Contributor Author

EnoahNetzach commented Dec 7, 2016 •
edited
Loading

Conversation about tests continuing in #1187.

mofelee added a commit to xiaohu-developer/create-react-app that referenced this pull request Dec 7, 2016
@mofelee
Merge branch 'master' into sparta-webapp
f8c88af 
* master: (30 commits)
  Relax peerDependencies for ESLint preset (facebook#1191)
  Update Webpack to fix source map issues (facebook#1188)
  Update webpack prod config (facebook#1181)
  Chrome 'open tab' reuse an empty tab when possible (facebook#1165)
  Use file-loader for svgs (facebook#1180)
  Fix Babel issues in tests by applying the right transforms (facebook#1179)
  [babel-preset-react-app] Temporary fix missing babel plugins (facebook#1177)
  Add Subresource Integrity support (facebook#1176)
  Remove path module from webpack config on eject. (facebook#1175)
  Don't strip stack traces of evaluated webpack bundles (facebook#1050)
  Add deploy to Firebase CDN on template's README (Closes facebook#374) (facebook#1143)
  Update e2e.sh (facebook#1167)
  Document what npm build does and pushState (facebook#933)
  Fix minor typo/grammar (facebook#1099)
  Add "npm run build silently fails" to Troubleshooting (facebook#1168)
  Add testURL to jest config (facebook#1120)
  Make jsx-no-undef rule an error (facebook#1159)
  Update CHANGELOG.md
  Publish
  Update changelog for 0.8.1
  ...
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
@EnoahNetzach @alexdriaguine
[babel-preset-react-app] Temporary fix missing babel plugins (faceboo…
73acff0 
…k#1177)

* temporary fix missing babel plugins

* Add an issue link
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
@EnoahNetzach @randycoulman
[babel-preset-react-app] Temporary fix missing babel plugins (faceboo…
67d3f4b 
…k#1177)

* temporary fix missing babel plugins

* Add an issue link
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
0.8.2
Development

Successfully merging this pull request may close these issues.
3 participants
@EnoahNetzach @gaearon @facebook-github-bot