-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome 'open tab' reuse an empty tab when possible #1165
Conversation
Nice, thanks for looking into this! Let me know when it's more fleshed out. |
We found a person who knows AppleScript. |
@gaearon I think it's ready for review 👍 Actually, It's my first time with Apple Script and I can't believe in myself I can write this language 😅 |
btw I found an unexpected behavior, if you have 2 windows open and not focus on the window which is running debugging tab. when we run the script, sometime it focuses on wrong window and won't select running tab. It works fine in all case if we're focusing on the debugging window 🙊 It happens in both master and this branch, I have debug the code and nothing wrong with it. maybe it's a bug running Chrome with Apple Script 🍎 |
I think I got it working correctly by the last commit. Can you please test that it works for all cases? |
@gaearon tested, all passes!! 👍 |
Thanks for fixing this! |
* master: (30 commits) Relax peerDependencies for ESLint preset (facebook#1191) Update Webpack to fix source map issues (facebook#1188) Update webpack prod config (facebook#1181) Chrome 'open tab' reuse an empty tab when possible (facebook#1165) Use file-loader for svgs (facebook#1180) Fix Babel issues in tests by applying the right transforms (facebook#1179) [babel-preset-react-app] Temporary fix missing babel plugins (facebook#1177) Add Subresource Integrity support (facebook#1176) Remove path module from webpack config on eject. (facebook#1175) Don't strip stack traces of evaluated webpack bundles (facebook#1050) Add deploy to Firebase CDN on template's README (Closes facebook#374) (facebook#1143) Update e2e.sh (facebook#1167) Document what npm build does and pushState (facebook#933) Fix minor typo/grammar (facebook#1099) Add "npm run build silently fails" to Troubleshooting (facebook#1168) Add testURL to jest config (facebook#1120) Make jsx-no-undef rule an error (facebook#1159) Update CHANGELOG.md Publish Update changelog for 0.8.1 ...
* Reuse empty tab on open chrome apple script * Break find tab into function * Use property to store found * Fix minor issues that caused window to not get active
* Reuse empty tab on open chrome apple script * Break find tab into function * Use property to store found * Fix minor issues that caused window to not get active
on
start
script - If there're no debugging tab (localhost:3000) open, we will try to use empty tab instead of create new one. (fixes #1157)Test plan
To invoke script, We can use both
npm/yarn start
or runosascript openChrome.applescript localhost:3000
inside/packages/react-dev-utils
folder .Test env