Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error with formatWebpackMessages trimming warnings #4656

Closed
wants to merge 4 commits into from
Closed

Fix error with formatWebpackMessages trimming warnings #4656

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d424ac3
Fix error with formatWebpackMessage trimming warnings
marcofugaro Jun 20, 2018
3a1ffb6
Check also for Module Error
marcofugaro Jun 28, 2018
31116d3
Add thread loader test in formatWebpackMessages
marcofugaro Jul 10, 2018
fdcdd9a
Remove other thread-loader noise in formatWebpackMessages
marcofugaro Jul 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion packages/react-dev-utils/formatWebpackMessages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,24 @@ function isLikelyASyntaxError(message) {
function formatMessage(message, isError) {
var lines = message.split('\n');

// Remove the useless Module Warning or Module Error message webpack sometimes outputs,
// it interferes with the thread loader stack clipping of the next few lines
if (
lines.length > 2 &&
(lines[1].indexOf('Module Warning') !== -1 ||
lines[1].indexOf('Module Error') !== -1 ||
/thread.loader/i.test(lines[1]))
) {
lines.splice(1, 1);
}

// Remove other thread-loader noise
if (lines.length > 2 && /thread.loader/i.test(lines[1])) {
lines.splice(1, 1);
}

// Remove extra newline.
if (lines.length > 2 && lines[1] === '') {
// Remove extra newline.
lines.splice(1, 1);
}

Expand Down