Fix error with formatWebpackMessages trimming warnings #4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a good fix. I'd like to get the test passing before merging it though. We're currently working on fixing the tests. |
kamranahmedse
approved these changes
Jul 7, 2018
|
Do you guys think we should check also for |
|
Done it, I think it makes sense if seomhow the |
|
Another case with the thread loader happened, this one happens when there are issues in the build, not the user code. Here is the
The error message was clipped also in this case, fixed it in fdcdd9a |
JayCanuck
added a commit
to enactjs/cli
that referenced
this pull request
Aug 27, 2018
…create-react-app#4656 is merged into react-dev-utils.
|
This is fixed in |
webOS101
pushed a commit
to enactjs/cli
that referenced
this pull request
Oct 4, 2018
* Initial implementation of Webpack 4 support. * Updated console-snoop, mocha-react-proptype-checker, and sinon * Workaround for incorrectly parsed error/warning stats until facebook/create-react-app#4656 is merged into react-dev-utils. * Update all remaining dependencies to latest releases. * Remove karma-dirty-chai (abandoned) * Use dirty-chai directly (rather than karma-dirty-chai plugin), redirect sinon requests to the prebuilt bundle (rather than esm bundle), hide performance output, simplify output to errors only, and update webpack config to support webpack 4. * Temporary workaround until karma-webpack issues are resolved and update published to NPM. * Updated dependencies. * Updates and fixed support for webpack import() syntax. * Babel cleanup, remove unneeded plugins, add react preset options, use loose option on class properties, and fix spacing * Support full browserslist format * Webpack message format fix has landed upstream * Webpack v4.19.1 added 'browser' mainfield support for electron-renderer * Updated dependencies * Switch from UglifyJsPlugin to TerserPlugin, as uglify-es was discontinued and terser is the new community-driven fork. * Fix css extension for chunk stylesheets * @enact/dev-utils 2.0.0 release update
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I've been using the updated react-dev-utils and found a bug in formatWebpackMessages that happens with newer webpack versions.
Basically webpack (or the thread-loader) in the
stats.toJson().warningsnow outputs also this line, containing a Module Warning or Module Error (?):so the
linesarray now becomes this (see second line):instead of the old one
This fucks with the thread-loader message remover and actually removes the body of the warning.
This PR checks if that line is present and removes it since it's not relevant to the user.