Fix formatWebpackMessages - fixes empty errors in console and overlay #4934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes some specific lines, rather than everything after the threadLoaderIndex
|
👍 I have too experienced the issue but never gotten to the bottom of it. |
|
I attempted to fix this more safely in #4656, but I think your solution is cleaner! Please someone bring in one of these PR! |
|
Hah, I didn't even notice your fix, it does seem safer. I guess one thing to ascertain is: do all module-loader errors insert the same 3 lines that I can naively destroy, or are there permutations? |
|
This is solved in the latest |
|
Good job @Timer! For anyone wondering the commits are 74e4527 and 710557f. Could you publish a new Also does this work correctly only assuming that this issue is fixed? webpack-contrib/eslint-loader#246. Or is that independent? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version of this function looked for any mention of thread-loaded and then deleted everything thereafter - which most of the time included the actual stack trace that you wanted.
My fix just gets rid of the 3 lines from the threadLoaderIndex and leaves the rest in.
I feel this is a very naive fix, as I don't know the full breadth of errors to check against to know if I'm lopping anything else off at the wrong moment.....but it seems to work in my very limited testing thus far
Before:
After:
