Only use safe options when packing CSS assets #4706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 29, 2018 18:55
|
Can you merge |
|
Meh, I trust you that this works. |
|
Guys, my app has been failing to build on Travis since 26 hrs ago and looks like your fix might have created problems. I re-ran previously working builds and they fail too. Looks like the react scripts has a problem with SourceMaps maybe?
|
|
@maddiereddy how is your travis build pulling in this change? |
|
https://github.com/maddiereddy/cribtrakr-client/blob/master/package.json#L13 it looks like its using 1.14? |
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
* support scoped packages for cra --scripts-version option * enable safe option to cssnano processor Fixes facebook#4682
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed z-index changes were overwritten.
It turns out that css-nano was used when optimizing css assets and safe option was not passed in.
https://cssnano.co/optimisations/zindex/
Verified that z-index no longer changes with this option.