Update jest version #4846
Update jest version #4846
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Tests appear to fail due to jsdom/jsdom#2304. This is happening with the current version of jest as well. |
|
There is already #4550 |
|
I haven't updated #4550 so this is fine. But the jsdom error needs to be fixed before proceeding. Can we pin jsdom dependency to a version. |
|
A fix appears to have been merged into jest master jestjs/jest#6792. |
This version of jest includes a fix for jsdom/jsdom#2304
|
The jsdom error appears to be fixed now with version 23.5.0 of jest. There are other failing tests, but I don't know weather the errors are due to these changes or an unstable CI setup. |
|
@Timer this also fixes one of the issues with CI (namely jestjs/jest#6766) if you want to tag it. |
* Update jest version * Update babel-jest version * Use testURL: http://localhost in jest configs. * Update to jest version 23.5 This version of jest includes a fix for jsdom/jsdom#2304 * "testURL": "http://localhost" is default with jest v23.5
Jest 23 adds support for
test.each#4845