-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: remove error about localStorage security #4890
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Removes "SecurityError: localStorage is not available for opaque origins" error in confusing-browser-globals, react-dev-utils, react-error-overlays and react-scripts
Dupe of #4846? |
@stramel Maybe 😕 #4897 (comment)
|
Hey @alex-pex, why the babel override? |
@mlazowik I don't remember. Maybe I was upgrading jest without upgrading babel-jest, or maybe babel7 was still beta and I ended up with 2 conflicting dependencies. |
Thanks for this, but we landed a separate Jest update PR. |
@Timer It's fine, no problem 😉 |
Upgrading Jest to latest version removes "SecurityError: localStorage is not available for opaque origins" error.