Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove error about localStorage security #4890

Closed
wants to merge 2 commits into from
Closed

Fix: remove error about localStorage security #4890

wants to merge 2 commits into from

Conversation

alex-pex
Copy link

@alex-pex alex-pex commented Aug 14, 2018

Upgrading Jest to latest version removes "SecurityError: localStorage is not available for opaque origins" error.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@alex-pex alex-pex changed the title Fix react-error-overlay tests Fix: react-error-overlay tests Aug 14, 2018
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@alex-pex alex-pex changed the title Fix: react-error-overlay tests Fix: remove error about localStorage security Aug 14, 2018
Removes "SecurityError: localStorage is not available for opaque
origins" error in confusing-browser-globals, react-dev-utils,
react-error-overlays and react-scripts
@stramel
Copy link

stramel commented Aug 20, 2018

Dupe of #4846?

@alex-pex
Copy link
Author

@stramel Maybe 😕 #4897 (comment)

There is a lot of PR trying to update Jest :

I don't know why none is merged. All current PR fail because tests are broken

@mlazowik
Copy link

Hey @alex-pex, why the babel override?

@alex-pex
Copy link
Author

@mlazowik I don't remember. Maybe I was upgrading jest without upgrading babel-jest, or maybe babel7 was still beta and I ended up with 2 conflicting dependencies.

@mlazowik
Copy link

@alex-pex either way, #4846 just landed so you close this one :)

@Timer
Copy link
Contributor

Timer commented Sep 18, 2018

Thanks for this, but we landed a separate Jest update PR.
Sorry!

@Timer Timer closed this Sep 18, 2018
@alex-pex alex-pex deleted the fix-error-overlay-testing branch September 20, 2018 11:02
@alex-pex
Copy link
Author

@Timer It's fine, no problem 😉

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants