Fix/file size reporter #5025
Fix/file size reporter #5025
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -98,6 +98,7 @@ function printFileSizesAfterBuild( | |||
| function removeFileNameHash(buildFolder, fileName) { | |||
| return fileName | |||
| .replace(buildFolder, '') | |||
| .replace(/\\/g, '/') | |||
There was a problem hiding this comment.
I think it would be better to just support both path separators in the below regex, what do you think?
There was a problem hiding this comment.
Not sure I follow.
The path are resolved differently from the start. These screens are before the change.
measureFileSizesBeforeBuild -> http://prntscr.com/kvxlyq
printFileSizesAfterBuild -> https://prnt.sc/kvxm6u
My solution was to just make sure they were always the same, if there is a smarter way sadly I'm not seeing it.
There was a problem hiding this comment.
Sorry, I should've been clearer.
Is this because asset.name always returns paths with forward slashes (/)? If so, this patch makes perfect sense!
There was a problem hiding this comment.
Yes. While measureFileSizesBeforeBuild returns the path delimiter for the current os.
|
Awesome, thanks! |
This PR addresses #4927
When getting the size of the previous build folder the paths were escaped
The screenshots are cluttered but the top part of the screen shots are the previousSizeMap before and after normalizing removeFileNameHash
The lower part is the asset.name before and after being run through removeFileNameHash
before: http://prntscr.com/kvw14e
after: http://prntscr.com/kvw0qs
Running the paths though the replace making sure they are all the same fixes the problem
result: http://prntscr.com/kvvwcp